Feature/compliance #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvgenKor
requested review from
AllFi,
akolotov,
lok52,
k1rill-fedoseev and
r0wdy1
AllFi
requested changes
Feb 6, 2023
r0wdy1
reviewed
Feb 6, 2023
AllFi
approved these changes
Feb 10, 2023
# Conflicts: # libzkbob-rs-wasm/Cargo.toml # libzkbob-rs-wasm/src/client/tx_parser.rs # libzkbob-rs-wasm/src/ts_types.rs # libzkbob-rs/Cargo.toml
|
The PR is ready to review. The branch was merged with dd branch to resolve conflicts |
AllFi
approved these changes
Mar 9, 2023
r0wdy1
reviewed
Mar 19, 2023
# Conflicts: # libzkbob-rs-wasm/src/client/mod.rs # libzkbob-rs/src/client/mod.rs # libzkbob-rs/src/delegated_deposit.rs
AllFi
reviewed
May 10, 2023
AllFi
approved these changes
May 10, 2023
removing commented code Co-authored-by: Alexander Filippov <aleksander.fill@gmail.com>
Sure, I forgot to remove it. Now it's fixed |
… to the actual libzeropool-zkbob
akolotov
added a commit
that referenced
this pull request
May 11, 2023
This merge contains the following set of changes: - API for revealing data required for compliance report (#46)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are required to generate detailed compliance report within the client library. Added following routines in the wasm library:
extract_decrypt_keysto get symmetric cipher keys needed to decrypt output tx items (account and notes)symcipher_decrypt_acc\symcipher_decrypt_accto decrypt account and notes from the memoblock (needed to verify report correctness during development)get_tx_inputsto find transaction inputs for the transaction: account and notes and intermediate nullifier from the input accountcalculate_nullifierto getting nullifier from the account