-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/cold storage #30
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works properly and looks good to me.
let params = &self.inner.borrow().params; | ||
let range = from_index.unwrap_or(0)..to_index.unwrap_or(u64::MAX); | ||
let bulk_results: Vec<ParseResult> = bulk.txs | ||
.into_par_iter() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
into_par_iter
doesn't work in singlecore version of wasm. It should be replaced with helpers::vec_into_iter
when we'll be merging this pr with #32.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, do not forget it is the main aim :)
Function
update_state_cold_storage
has been implemented in the wasm libraryThis routine used for sync local state from binary files prepared with https://github.com/zkBob/zkbob-pool-storage tool