Modernize fork hooks to not conflict with other gems#109
Open
casperisfine wants to merge 1 commit intozk-ruby:masterfrom
Open
Modernize fork hooks to not conflict with other gems#109casperisfine wants to merge 1 commit intozk-ruby:masterfrom
casperisfine wants to merge 1 commit intozk-ruby:masterfrom
Conversation
Fix: zk-ruby#108 `Module#prepend` is much more composable than alias method chains. This is essentially a port of the Active Support implementation.
|
@casperisfine thank you for taking a look at this! The forking logic is not my strong suit. I was able to confirm that the related error when running with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #108
Module#prependis much more composable than alias method chains.This is essentially a port of the Active Support implementation.
FYI: @niodice