Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lsp): ignore diagnostic check within code blocks #399

Merged
merged 10 commits into from
Apr 6, 2024
Merged

fix(lsp): ignore diagnostic check within code blocks #399

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c21c2cd
fix(lsp): ignore diagnostic check within code blocks
Rahlir Apr 2, 2024
2bf9b5d
chore(lsp): cleanup commented out code, add new comment
Rahlir Apr 2, 2024
d3aab27
fix(lsp): fix behavior when inline code is a first string on the line
Rahlir Apr 4, 2024
37ea59a
clarify comments and move if block before appendLink()
tjex Apr 5, 2024
d363631
hard code insideInline boolean instead of inverting it
tjex Apr 5, 2024
4df45d2
Revert "hard code insideInline boolean instead of inverting it"
tjex Apr 5, 2024
9161a5b
remove my comment, code is clear enough
tjex Apr 5, 2024
b68df7f
wip: refactor if statement into function
tjex Apr 5, 2024
ddc77c4
refactor if checks into local function
tjex Apr 6, 2024
ea2ca9e
update code comment
tjex Apr 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore(lsp): cleanup commented out code, add new comment
  • Loading branch information
@Rahlir
Rahlir committed Apr 2, 2024
commit 2bf9b5ddd073a533243563029f5b9befc1396ccc
29 changes: 1 addition & 28 deletions internal/adapter/lsp/document.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,41 +197,14 @@ func (d *document) DocumentLinkAt(pos protocol.Position) (*documentLink, error)
return nil, nil
}

// Recursive function to check whether a link is within inline code block.
Rahlir marked this conversation as resolved.
Show resolved Hide resolved
func linkWithinInlineCode(strBuffer string, linkStart, linkEnd int, insideInline bool) bool {
if backtickId := strings.Index(strBuffer, "`"); backtickId > 0 && backtickId < linkEnd {
Rahlir marked this conversation as resolved.
Show resolved Hide resolved
return linkWithinInlineCode(strBuffer[backtickId+1:],
linkStart-backtickId-1, linkEnd-backtickId-1, !insideInline)
} else {
return insideInline
}

// backtickStart += cursorPos
// if insideInline {
// if backtickStart >= end {
// return true
// }
// return linkWithinInlineCode(line[backtickStart+1:], start-backtickStart-1, end-backtickStart-1, false)
// } else if backtickStart < start {
// return linkWithinInlineCode(line[backtickStart+1:], start-backtickStart-1, end-backtickStart-1, !insideInline)
// }

// if backtickStart < start {
// backtickEnd := strings.Index(line[backtickStart+1:], "`")
// if backtickEnd >= 0 {
// backtickEnd += backtickStart + 1
// if backtickEnd >= end {
// return true
// } else {
// return linkWithinInlineCode(line[backtickEnd+1:], start-backtickEnd-1, end-backtickEnd-1, false)
// }
// } else {
// return true
// }
// }
// return false
//} else {
// return insideInline
//}
}

// DocumentLinks returns all the internal and external links found in the
Expand Down