refactor(*): apply new lint rule set up and lint fix on new rules (sv…

…erweij#273)

.eslintrc.json

@@ -1,6 +1,9 @@
 {
   "root": true,
-  "extends": ["./configs/eslint-config.json", "eslint-config-prettier"],
+  "extends": ["moving-meadow"],
+  "rules": {
+    "security/detect-non-literal-fs-filename": "off"
+  },
   "overrides": [
     {
       "files": ["test/**/*.js"],

Makefile

@@ -5,7 +5,7 @@ GENERATED_SOURCES=src/cli/init-config/config.js.template.js \
 	src/report/csv/csv.template.js \
 	src/report/dot/dot.template.js \
 	src/report/html/html.template.js \
-	src/report/err-html/err-html.template.js \
+	src/report/error-html/error-html.template.js \
 	src/schema/configuration.schema.json \
 	src/schema/cruise-result.schema.json
 

bin/depcruise-fmt.js

@@ -1,13 +1,13 @@
 #!/usr/bin/env node
-const validateNodeEnv = require("../src/cli/validate-node-env");
+const validateNodeEnvironment = require("../src/cli/validate-node-environment");
 
 function formatError(pError) {
   process.stderr.write(pError.message);
   process.exitCode = 1;
 }
 
 try {
-  validateNodeEnv();
+  validateNodeEnvironment();
 
   // importing things only after the validateNodeEnv check so we can show an understandable
   // error. Otherwise, on unsupported platforms we would show a stack trace, which is

bin/dependency-cruise.js

@@ -1,8 +1,8 @@
 #!/usr/bin/env node
-const validateNodeEnv = require("../src/cli/validate-node-env");
+const validateNodeEnvironment = require("../src/cli/validate-node-environment");
 
 try {
-  validateNodeEnv();
+  validateNodeEnvironment();
 
   // importing things only after the validateNodeEnv check so we can show an understandable
   // error. Otherwise, on unsupported platforms we would show a stack trace, which is