Skip to content

optimising bash scripts. #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 25, 2017
Merged

optimising bash scripts. #1

merged 1 commit into from
Dec 25, 2017

Conversation

codenio
Copy link
Contributor

@codenio codenio commented Dec 17, 2017

we could dynamically feed those streams into diff instead of storing it in files.

we could dynamically feed those streams into diff instead of storing it in files.
Copy link
Owner

@zjj2wry zjj2wry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zjj2wry
Copy link
Owner

zjj2wry commented Dec 25, 2017

@aananthraj thank you

@zjj2wry zjj2wry merged commit f06a68a into zjj2wry:master Dec 25, 2017
@xiangpengzhao
Copy link

@aananthraj awesome! 👍 💯

@codenio
Copy link
Contributor Author

codenio commented Feb 7, 2018

thanks @zjj2wry 👍 and @xiangpengzhao 😊 , for the support and the feedback.

FYI, new features like,

  • diff on upgrade
  • diff on rollback
  • diff between revisions

have been made available as a pull request in helm-diff go plugin, and i am waiting for it to be merged.

It would be helpful, if you people could give your opinion/suggestion on those features.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants