Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import machine user with secret #162

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

eliobischof
Copy link
Member

Definition of Ready

  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • All non-functional requirements are met
  • The generic lifecycle acceptance test passes for affected resources.
  • Examples are up-to-date and meaningful. The provider version is incremented.
  • Docs are generated.
  • Code is generated where possible.

@eliobischof eliobischof self-assigned this Feb 22, 2024
@eliobischof eliobischof mentioned this pull request Feb 22, 2024
12 tasks
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (generate_machine_secret@6d59646). Click here to learn what that means.

Files Patch % Lines
zitadel/machine_user/funcs.go 0.00% 1 Missing and 2 partials ⚠️
zitadel/helper/import.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##             generate_machine_secret     #162   +/-   ##
==========================================================
  Coverage                           ?   63.11%           
==========================================================
  Files                              ?      159           
  Lines                              ?    12881           
  Branches                           ?        0           
==========================================================
  Hits                               ?     8130           
  Misses                             ?     3467           
  Partials                           ?     1284           
Flag Coverage Δ
acceptance-tests 63.11% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stebenz stebenz merged commit 137cf91 into generate_machine_secret Feb 22, 2024
4 checks passed
@stebenz stebenz deleted the fix-with-secret-import branch February 22, 2024 14:40
renovate bot referenced this pull request in smartive/cas-fee-adv-mumble-api Apr 23, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [zitadel](https://registry.terraform.io/providers/zitadel/zitadel)
([source](https://togithub.com/zitadel/terraform-provider-zitadel)) |
required_provider | minor | `1.0.6` -> `1.1.1` |

---

### Release Notes

<details>
<summary>zitadel/terraform-provider-zitadel (zitadel)</summary>

###
[`v1.1.1`](https://togithub.com/zitadel/terraform-provider-zitadel/releases/tag/v1.1.1)

[Compare
Source](https://togithub.com/zitadel/terraform-provider-zitadel/compare/v1.1.0...v1.1.1)

#### What's Changed

- fix: saml trigger type by
[@&#8203;eliobischof](https://togithub.com/eliobischof) in
[https://github.com/zitadel/terraform-provider-zitadel/pull/163](https://togithub.com/zitadel/terraform-provider-zitadel/pull/163)

**Full Changelog**:
zitadel/terraform-provider-zitadel@v1.1.0...v1.1.1

###
[`v1.1.0`](https://togithub.com/zitadel/terraform-provider-zitadel/releases/tag/v1.1.0)

[Compare
Source](https://togithub.com/zitadel/terraform-provider-zitadel/compare/v1.0.7...v1.1.0)

#### What's Changed

- chore: update pm board action by
[@&#8203;hifabienne](https://togithub.com/hifabienne) in
[https://github.com/zitadel/terraform-provider-zitadel/pull/156](https://togithub.com/zitadel/terraform-provider-zitadel/pull/156)
- docs: Fix broken links to API documentation and concepts. by
[@&#8203;tired-engineer](https://togithub.com/tired-engineer) in
[https://github.com/zitadel/terraform-provider-zitadel/pull/157](https://togithub.com/zitadel/terraform-provider-zitadel/pull/157)
- fix: import machine user with secret by
[@&#8203;eliobischof](https://togithub.com/eliobischof) in
[https://github.com/zitadel/terraform-provider-zitadel/pull/162](https://togithub.com/zitadel/terraform-provider-zitadel/pull/162)
- fix: enum docs for trigger_actions by
[@&#8203;stebenz](https://togithub.com/stebenz) in
[https://github.com/zitadel/terraform-provider-zitadel/pull/160](https://togithub.com/zitadel/terraform-provider-zitadel/pull/160)
- feat: generate machine secret by
[@&#8203;stebenz](https://togithub.com/stebenz) in
[https://github.com/zitadel/terraform-provider-zitadel/pull/161](https://togithub.com/zitadel/terraform-provider-zitadel/pull/161)

#### New Contributors

- [@&#8203;tired-engineer](https://togithub.com/tired-engineer) made
their first contribution in
[https://github.com/zitadel/terraform-provider-zitadel/pull/157](https://togithub.com/zitadel/terraform-provider-zitadel/pull/157)

**Full Changelog**:
zitadel/terraform-provider-zitadel@v1.0.7...v1.1.0

###
[`v1.0.7`](https://togithub.com/zitadel/terraform-provider-zitadel/releases/tag/v1.0.7)

[Compare
Source](https://togithub.com/zitadel/terraform-provider-zitadel/compare/v1.0.6...v1.0.7)

#### What's Changed

- Update tagline by [@&#8203;mffap](https://togithub.com/mffap) in
[https://github.com/zitadel/terraform-provider-zitadel/pull/155](https://togithub.com/zitadel/terraform-provider-zitadel/pull/155)
- fix: add saml application by
[@&#8203;stebenz](https://togithub.com/stebenz) in
[https://github.com/zitadel/terraform-provider-zitadel/pull/154](https://togithub.com/zitadel/terraform-provider-zitadel/pull/154)

**Full Changelog**:
zitadel/terraform-provider-zitadel@v1.0.6...v1.0.7

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 9pm,before 6am" in timezone
Europe/Zurich, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/smartive/cas-fee-adv-mumble-api).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNTMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjIyMC4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants