Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add saml application #154

Merged
merged 6 commits into from
Jan 31, 2024
Merged

fix: add saml application #154

merged 6 commits into from
Jan 31, 2024

Conversation

stebenz
Copy link
Contributor

@stebenz stebenz commented Jan 24, 2024

SAML applications can be managed with ZITADEL's terraform provider

Definition of Ready

  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • All non-functional requirements are met
  • The generic lifecycle acceptance test passes for affected resources.
  • Examples are up-to-date and meaningful. The provider version is incremented.
  • Docs are generated.
  • Code is generated where possible.

@stebenz stebenz self-assigned this Jan 24, 2024
@stebenz stebenz linked an issue Jan 24, 2024 that may be closed by this pull request
2 tasks
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 69 lines in your changes are missing coverage. Please review.

Comparison is base (a1c0eaa) 63.20% compared to head (720e986) 63.32%.
Report is 1 commits behind head on main.

❗ Current head 720e986 differs from pull request most recent head 49fb09f. Consider uploading reports for the commit 49fb09f to get more accurate results

Files Patch % Lines
zitadel/application_saml/funcs.go 53.90% 46 Missing and 19 partials ⚠️
zitadel/application_api/funcs.go 0.00% 1 Missing and 1 partial ⚠️
zitadel/application_oidc/funcs.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #154      +/-   ##
==========================================
+ Coverage   63.20%   63.32%   +0.12%     
==========================================
  Files         156      159       +3     
  Lines       12609    12840     +231     
==========================================
+ Hits         7969     8131     +162     
- Misses       3379     3427      +48     
- Partials     1261     1282      +21     
Flag Coverage Δ
acceptance-tests 63.32% <70.63%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@livio-a livio-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should allow more options (in the future) for the metadata (url / file / ...)

but looks ok from what i understand

@stebenz stebenz merged commit 91e6957 into main Jan 31, 2024
2 checks passed
@stebenz stebenz deleted the application-saml branch January 31, 2024 15:49
renovate bot referenced this pull request in smartive/cas-fee-adv-mumble-api Apr 23, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [zitadel](https://registry.terraform.io/providers/zitadel/zitadel)
([source](https://togithub.com/zitadel/terraform-provider-zitadel)) |
required_provider | minor | `1.0.6` -> `1.1.1` |

---

### Release Notes

<details>
<summary>zitadel/terraform-provider-zitadel (zitadel)</summary>

###
[`v1.1.1`](https://togithub.com/zitadel/terraform-provider-zitadel/releases/tag/v1.1.1)

[Compare
Source](https://togithub.com/zitadel/terraform-provider-zitadel/compare/v1.1.0...v1.1.1)

#### What's Changed

- fix: saml trigger type by
[@&#8203;eliobischof](https://togithub.com/eliobischof) in
[https://github.com/zitadel/terraform-provider-zitadel/pull/163](https://togithub.com/zitadel/terraform-provider-zitadel/pull/163)

**Full Changelog**:
zitadel/terraform-provider-zitadel@v1.1.0...v1.1.1

###
[`v1.1.0`](https://togithub.com/zitadel/terraform-provider-zitadel/releases/tag/v1.1.0)

[Compare
Source](https://togithub.com/zitadel/terraform-provider-zitadel/compare/v1.0.7...v1.1.0)

#### What's Changed

- chore: update pm board action by
[@&#8203;hifabienne](https://togithub.com/hifabienne) in
[https://github.com/zitadel/terraform-provider-zitadel/pull/156](https://togithub.com/zitadel/terraform-provider-zitadel/pull/156)
- docs: Fix broken links to API documentation and concepts. by
[@&#8203;tired-engineer](https://togithub.com/tired-engineer) in
[https://github.com/zitadel/terraform-provider-zitadel/pull/157](https://togithub.com/zitadel/terraform-provider-zitadel/pull/157)
- fix: import machine user with secret by
[@&#8203;eliobischof](https://togithub.com/eliobischof) in
[https://github.com/zitadel/terraform-provider-zitadel/pull/162](https://togithub.com/zitadel/terraform-provider-zitadel/pull/162)
- fix: enum docs for trigger_actions by
[@&#8203;stebenz](https://togithub.com/stebenz) in
[https://github.com/zitadel/terraform-provider-zitadel/pull/160](https://togithub.com/zitadel/terraform-provider-zitadel/pull/160)
- feat: generate machine secret by
[@&#8203;stebenz](https://togithub.com/stebenz) in
[https://github.com/zitadel/terraform-provider-zitadel/pull/161](https://togithub.com/zitadel/terraform-provider-zitadel/pull/161)

#### New Contributors

- [@&#8203;tired-engineer](https://togithub.com/tired-engineer) made
their first contribution in
[https://github.com/zitadel/terraform-provider-zitadel/pull/157](https://togithub.com/zitadel/terraform-provider-zitadel/pull/157)

**Full Changelog**:
zitadel/terraform-provider-zitadel@v1.0.7...v1.1.0

###
[`v1.0.7`](https://togithub.com/zitadel/terraform-provider-zitadel/releases/tag/v1.0.7)

[Compare
Source](https://togithub.com/zitadel/terraform-provider-zitadel/compare/v1.0.6...v1.0.7)

#### What's Changed

- Update tagline by [@&#8203;mffap](https://togithub.com/mffap) in
[https://github.com/zitadel/terraform-provider-zitadel/pull/155](https://togithub.com/zitadel/terraform-provider-zitadel/pull/155)
- fix: add saml application by
[@&#8203;stebenz](https://togithub.com/stebenz) in
[https://github.com/zitadel/terraform-provider-zitadel/pull/154](https://togithub.com/zitadel/terraform-provider-zitadel/pull/154)

**Full Changelog**:
zitadel/terraform-provider-zitadel@v1.0.6...v1.0.7

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 9pm,before 6am" in timezone
Europe/Zurich, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/smartive/cas-fee-adv-mumble-api).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNTMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjIyMC4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SAML applications
2 participants