Preserve docblocks for consecutive promoted properties (#1627)

zircote · Jul 15, 2024 · 2a6fa1d · 2a6fa1d
1 parent e28255e
commit 2a6fa1d
Show file tree

Hide file tree

Showing 4 changed files with 31 additions and 1 deletion.
diff --git a/src/Analysers/AttributeAnnotationFactory.php b/src/Analysers/AttributeAnnotationFactory.php
@@ -65,6 +65,7 @@ public function build(\Reflector $reflector, Context $context): array
                         foreach ($rp->getAttributes($attributeName, \ReflectionAttribute::IS_INSTANCEOF) as $attribute) {
                             /** @var OA\Property|OA\Parameter|OA\RequestBody $instance */
                             $instance = $attribute->newInstance();
+
                             $type = (($rnt = $rp->getType()) && $rnt instanceof \ReflectionNamedType) ? $rnt->getName() : Generator::UNDEFINED;
                             $nullable = $rnt ? $rnt->allowsNull() : true;
 
@@ -81,7 +82,7 @@ public function build(\Reflector $reflector, Context $context): array
 
                                 if ($rp->isPromoted()) {
                                     // ensure each property has its own context
-                                    $instance->_context = new Context([], $instance->_context);
+                                    $instance->_context = new Context(['generated' => true, 'annotations' => [$instance]], $context);
 
                                     // promoted parameter - docblock is available via class/property
                                     if ($comment = $rp->getDeclaringClass()->getProperty($rp->getName())->getDocComment()) {

diff --git a/tests/Fixtures/Scratch/PromotedProperty.php b/tests/Fixtures/Scratch/PromotedProperty.php
@@ -27,6 +27,14 @@ public function __construct(
         #[OAT\Property(property: 'thevalue')]
         public string $value = '',
 
+        /**
+         * Other value.
+         *
+         * @var string
+         */
+        #[OAT\Property(property: 'other')]
+        public string $other = '',
+
         /**
          * Property meta.
          *
@@ -35,6 +43,15 @@ public function __construct(
          * @OA\Property(property="themeta")
          */
         public string $meta = '',
+
+        /**
+         * Property different.
+         *
+         * @var string
+         *
+         * @OA\Property()
+         */
+        public string $different = '',
     ) {
     }
 }

diff --git a/tests/Fixtures/Scratch/PromotedProperty3.0.0.yaml b/tests/Fixtures/Scratch/PromotedProperty3.0.0.yaml
@@ -17,10 +17,16 @@ components:
         thevalue:
           description: 'Property value.'
           type: string
+        other:
+            description: 'Other value.'
+            type: string
         thename:
           description: 'Property name.'
           type: string
         themeta:
           description: 'Property meta.'
           type: string
+        different:
+            description: 'Property different.'
+            type: string
       type: object
diff --git a/tests/Fixtures/Scratch/PromotedProperty3.1.0.yaml b/tests/Fixtures/Scratch/PromotedProperty3.1.0.yaml
@@ -17,10 +17,16 @@ components:
         thevalue:
           description: 'Property value.'
           type: string
+        other:
+            description: 'Other value.'
+            type: string
         thename:
           description: 'Property name.'
           type: string
         themeta:
           description: 'Property meta.'
           type: string
+        different:
+            description: 'Property different.'
+            type: string
       type: object