Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protobuf performance fix #473

Merged
merged 8 commits into from
Dec 23, 2022
Merged

Protobuf performance fix #473

merged 8 commits into from
Dec 23, 2022

Conversation

vigoo
Copy link
Contributor

@vigoo vigoo commented Dec 23, 2022

Resolves #470

Before:

[info] ProtobufBenchmarks.encodeLargeByteChunk      30721    1000  thrpt   10  51.726 ± 1.184  ops/s
[info] ProtobufBenchmarks.decodeLargeByteChunk      30721    1000  thrpt   10  0.029 ±  0.001  ops/s

After:

[info] ProtobufBenchmarks.encodeLargeByteChunk      30721    1000  thrpt   10   87.444 ± 0.345  ops/s
[info] ProtobufBenchmarks.decodeLargeByteChunk      30721    1000  thrpt   10  563.555 ± 0.775  ops/s

@vigoo vigoo requested a review from a team as a code owner December 23, 2022 17:17
@adamgfraser adamgfraser merged commit dc294f2 into zio:main Dec 23, 2022
@vigoo vigoo deleted the protobuf-perf-fix branch December 23, 2022 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamgfraser adamgfraser adamgfraser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Protobuf Codec is slower than expected on modest input
2 participants
@vigoo @adamgfraser