Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up and fix DynamicValue schema handling #452

Merged
merged 2 commits into from
Dec 5, 2022

Conversation

vigoo
Copy link
Contributor

@vigoo vigoo commented Dec 4, 2022

  • The implicit schema for DynamicValue is now Schema.Dynamic as it is a single placeholder when the schema is serialized instead of redundant inclusion of the whole real schema
  • The real schema for DynamicValue is defined as DynamicValue.schema as with other types (DynamicValueSchema should not be private #332) and it is made public for implementing codecs outside of zio.schema
  • Added some new tests that include DynamicValue in generated schemas
  • Fixed the issue that MetaSchema including a Dynamic node was not serializable and tests this with JSON and Protobuf

@vigoo vigoo requested a review from a team as a code owner December 4, 2022 22:34
@vigoo vigoo merged commit 04cc81b into zio:main Dec 5, 2022
@vigoo vigoo deleted the dynamicvalue-fix branch December 5, 2022 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants