Clean up and fix DynamicValue schema handling #452
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DynamicValue
is nowSchema.Dynamic
as it is a single placeholder when the schema is serialized instead of redundant inclusion of the whole real schemaDynamicValue
is defined asDynamicValue.schema
as with other types (DynamicValueSchema should not be private #332) and it is made public for implementing codecs outside ofzio.schema
DynamicValue
in generated schemasMetaSchema
including aDynamic
node was not serializable and tests this with JSON and Protobuf