Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DynamicValue.fromSchemaAndValue and codecs stack safe #389

Merged
merged 21 commits into from
Nov 7, 2022

Conversation

vigoo
Copy link
Contributor

@vigoo vigoo commented Oct 27, 2022

Resolves #340
Resolves #286

@vigoo vigoo requested a review from a team as a code owner October 27, 2022 15:48
@vigoo
Copy link
Contributor Author

vigoo commented Oct 27, 2022

Work in progress - making a generic way to deal with stack safety and updating other parts of the library to build on that

@vigoo vigoo changed the title Make DynamicValue.fromSchemaAndValue stack safe Make DynamicValue.fromSchemaAndValue and codecs stack safe Oct 28, 2022
adamgfraser
adamgfraser previously approved these changes Nov 6, 2022
adamgfraser
adamgfraser previously approved these changes Nov 6, 2022
@vigoo vigoo merged commit 94ae4cb into zio:main Nov 7, 2022
@vigoo vigoo deleted the stacksafety branch November 7, 2022 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DynamicValue.fromSchemaAndValue is not stack safe Recursive data-type can't be encoded with ProtobufCodec
2 participants