Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish Docs to NPM Registry #371

Merged
merged 38 commits into from
Oct 30, 2022
Merged

Conversation

khajavi
Copy link
Member

@khajavi khajavi commented Oct 17, 2022

In order to be able to have integrated documents in zio.dev, we need to publish documents to the npm registry and then, fetch them in the zio.dev build process.

@khajavi khajavi marked this pull request as ready for review October 17, 2022 16:20
@khajavi khajavi requested a review from a team as a code owner October 17, 2022 16:20
@khajavi
Copy link
Member Author

khajavi commented Oct 27, 2022

I've just updated the work with the main branch.

@jdegoes @adamgfraser
This is ready for your review.

@jdegoes
Copy link
Member

jdegoes commented Oct 28, 2022

@khajavi Is this a test or do you want this merged in? May be best to wait for sbt-zio?

@khajavi
Copy link
Member Author

khajavi commented Oct 29, 2022

@jdegoes

This work was the first try on integration. The zio-sbt project will automate most of this work.

I tested this work on my forked GitHub account and the GitHub workflow works properly. We can merge it, and double-check that.
Another option is to wait, and I will add more commits to this PR which will use zio-sbt.

@jdegoes jdegoes merged commit 41cbae0 into zio:main Oct 30, 2022
@jdegoes
Copy link
Member

jdegoes commented Oct 30, 2022

@khajavi Merged!

@khajavi
Copy link
Member Author

khajavi commented Oct 30, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants