-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support async command evaluation #917
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mijicd
reviewed
Nov 15, 2023
modules/redis/src/main/scala/zio/redis/internal/RedisExecutor.scala
Outdated
Show resolved
Hide resolved
modules/redis/src/main/scala/zio/redis/internal/RedisExecutor.scala
Outdated
Show resolved
Hide resolved
modules/redis/src/main/scala/zio/redis/internal/SingleNodeExecutor.scala
Outdated
Show resolved
Hide resolved
mijicd
previously approved these changes
Nov 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few questions/nitpicks, otherwise LGTM
modules/redis/src/main/scala/zio/redis/internal/RedisEnvironment.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: Dejan Mijić <dmijic@acm.org>
mijicd
approved these changes
Nov 17, 2023
mijicd
changed the title
Async support (for ticket #916)
Support async command evaluation
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #916
Hey @mijicd,
I've hacked together something to implement the improved async support that I laid out in #916. The code could certainly be made a little bit prettier here and there, but the primary aim here is to try out the idea and see if you consider this a viable way forward.
The essential changes are:
requests.offer(…stuff…) *> promise.await
torequests.offer(…stuff…).as(promise.await))
, which makes it possible to continue processing as soon as the request was placed in the queue (SingleNodeExecutor.scala:35)Redis
trait to indicate whether it will returnUIO[IO[RedisError, A]]
orIO[RedisError, A]
(Redis.scala:23)Redis.singleNode
andRedis.local
to provide both a synchronous and an asynchronous implementation of the Redis client (Redis.scala:45)The resources like Queues and the Redis connection are shared between the synchronous and asynchronous Redis client, see the changes in
SingleNodeExecutor
.The biggest drawback right now is that I haven't yet looked into the cluster support, so the
cluster
ZLayer doesn't give you anAsyncRedis
object. I'd like to get some feedback on the general approach first before tackling that.