Add 'WithScore' option both to 'zRank' and 'zRevRank' commands #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mijicd
previously approved these changes
Apr 15, 2023
| @@ -82,6 +82,8 @@ trait SortedSets { | |||
|
|
|||
| type MemberScores[+M] = Chunk[MemberScore[M]] | |||
|
|
|||
| sealed case class RankScore(score: Double, rank: Long) | |||
There was a problem hiding this comment.
Suggested change
| sealed case class RankScore(score: Double, rank: Long) | |
| sealed case class RankScore(rank: Long, score: Double) |
We should consider introducing newtypes (maybe through zio-prelude) to represent things like Rank consistently and "cost-free". That's a topic for a separate PR, though.
mijicd
approved these changes
Apr 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Part of #804
docker-composeto use Redis 7.2.WithScoreflag.zRankWithScoreandzRevRankWithScore.WithScoresInputinstead ofArbitraryValueInput[String]().STRALGO LCSwithLCS. Removed support for strings. Changed API. Reason: "Remove STRALGO command, preserve LCS a standalone command which only works on keys". More info here.