Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganize internals and layers usage #788

Merged
merged 19 commits into from
Mar 29, 2023
Merged

Reorganize internals and layers usage #788

merged 19 commits into from
Mar 29, 2023

Conversation

mijicd
Copy link
Member

@mijicd mijicd commented Mar 29, 2023

Summary

  • hide internals
  • place layers in implementation companions
  • remove unnecessary abstractions (e.g. connection)

@mijicd mijicd marked this pull request as ready for review March 29, 2023 00:47
@mijicd mijicd requested a review from a team as a code owner March 29, 2023 00:47
@mijicd mijicd requested a review from ioleo March 29, 2023 00:47
ioleo
ioleo previously approved these changes Mar 29, 2023
View reviewed changes
Copy link
Member

@ioleo ioleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

drmarjanovic
drmarjanovic previously approved these changes Mar 29, 2023
View reviewed changes
@mijicd mijicd merged commit a92f139 into zio:master Mar 29, 2023
@mijicd mijicd deleted the feature/cleanup branch March 29, 2023 10:24
@mijicd mijicd mentioned this pull request Mar 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drmarjanovic drmarjanovic drmarjanovic left review comments

@ioleo ioleo ioleo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mijicd @ioleo @drmarjanovic