Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement PubSub api #714
Implement PubSub api #714
Changes from 12 commits
a280504
cd4a3f3
a01213d
9541519
ba89a59
9723182
65b524b
892ba20
43edb47
a6f74fa
c7decb7
b6438f0
5fb75e4
ce97f95
a25805b
fd0b303
7cb1491
2ab2db1
87eee71
f532e4b
e9e2a3c
014d2e4
49c141b
8b6ce73
f44c7fc
758ea9b
9febcf8
92aea5e
3fc77c0
3c8a307
0ea75a1
ef3b9f1
478577b
c4105ff
f432815
149ae4b
67652e6
8606409
6a3f68f
1a0862f
92457c4
bf52e26
c027295
a154683
592d327
386fefd
415f75e
1699211
be11d67
552e002
e218b08
ac85cb9
dadb5e7
88c3f4e
6e50d4d
5ca98e7
539ef3f
63cc263
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should hide these from the end user. These should be in a dedicated
PubSubCommand
file.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved it to its own file but do we need to add package private access modifier?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that we do if it's not part of the
api
interface.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added package private accessor