Cluster support #653

anatolysergeev · 2022-10-30T07:03:18Z

Partially done #151

partially closed issue zio#151

mijicd

Thanks for taking care of this!

testcontainers/redis-cluster-compose.yml

redis/src/test/scala/zio/redis/executor/cluster/RedisClusterExecutorLiveSpec.scala

build.sbt

redis/src/main/scala/zio/redis/RedisCommand.scala

redis/src/main/scala/zio/redis/executor/RedisConnection.scala

redis/src/main/scala/zio/redis/executor/RedisExecutor.scala

redis/src/main/scala/zio/redis/executor/cluster/RedisClusterConfig.scala

redis/src/main/scala/zio/redis/executor/cluster/RedisClusterExecutorLive.scala

# Conflicts: # redis/src/test/scala/zio/redis/ApiSpec.scala # redis/src/test/scala/zio/redis/ByteStreamSpec.scala

delete some unrelated changes

move redis uri to separate class

mijicd

2nd pass done

redis/src/main/scala/zio/redis/RedisClusterConfig.scala

redis/src/main/scala/zio/redis/RedisClusterExecutorLive.scala

redis/src/main/scala/zio/redis/options/Cluster.scala

redis/src/main/scala/zio/redis/package.scala

redis/src/main/scala/zio/redis/RedisConnection.scala

mijicd

A few minor remarks from my side, otherwise looks good to go. Before merging it, please adjust the PR comment to avoid accidentally closing the issue (i.e., right now, it contains a "magic" word close), and update the list in the issue.

Thank you!

redis/src/main/scala/zio/redis/api/Cluster.scala

redis/src/main/scala/zio/redis/codec/CRC16.scala

redis/src/main/scala/zio/redis/options/Cluster.scala

fix some review comments

anatolysergeev added 2 commits October 29, 2022 10:29

prepare code for cluster implementation

c7290d0

add cluster support

fe08881

partially closed issue zio#151

anatolysergeev requested review from mijicd and a team as code owners October 30, 2022 07:03

anatolysergeev force-pushed the ussue-151 branch from e49bfae to f2d39e7 Compare October 30, 2022 08:32

mijicd reviewed Oct 30, 2022

View reviewed changes

anatolysergeev force-pushed the ussue-151 branch 2 times, most recently from 6560514 to 9e0ed1f Compare October 30, 2022 09:39

fix compilation errors

1e1749d

anatolysergeev force-pushed the ussue-151 branch from 9e0ed1f to 1e1749d Compare October 30, 2022 09:49

anatolysergeev added 11 commits October 30, 2022 21:05

some improvement to redis cluster compose file

ad8a938

fix comments

0ee2b0a

Merge branch 'master' into ussue-151

568cbb1

# Conflicts: # redis/src/test/scala/zio/redis/ApiSpec.scala # redis/src/test/scala/zio/redis/ByteStreamSpec.scala

fix errors after merge

0fb8e06

fix comments

0a0f472

delete some unrelated changes

delete parentheses from asking and slots method

0a81318

revert redis config name

ea23dda

move redis uri to separate class

revert reorganization of folders

d03c367

fix banchmark 2.12.16 compilation

d043d2c

fix scala 3 compilatioin errors

ff28058

fix lint

5bb5db6

mijicd reviewed Nov 1, 2022

View reviewed changes

anatolysergeev added 3 commits November 5, 2022 15:16

fix review comments

02ceb18

fix review comments

721cc10

fix lint errors

cfab224

mijicd previously approved these changes Nov 10, 2022

View reviewed changes

add documentation to the cluster methods

3dffebb

fix some review comments

anatolysergeev dismissed mijicd’s stale review via 3dffebb November 10, 2022 20:34

mijicd approved these changes Nov 12, 2022

View reviewed changes

anatolysergeev merged commit 340672d into zio:master Nov 12, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cluster support #653

Cluster support #653

anatolysergeev commented Oct 30, 2022 •

edited

Loading

mijicd left a comment

mijicd left a comment

mijicd left a comment

Cluster support #653

Cluster support #653

Conversation

anatolysergeev commented Oct 30, 2022 • edited Loading

mijicd left a comment

Choose a reason for hiding this comment

mijicd left a comment

Choose a reason for hiding this comment

mijicd left a comment

Choose a reason for hiding this comment

anatolysergeev commented Oct 30, 2022 •

edited

Loading