Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ZUNION command (#357) #364

Merged
merged 7 commits into from
May 4, 2021
Merged

Conversation

rfmejia
Copy link
Contributor

@rfmejia rfmejia commented May 2, 2021

Closes #357

This PR implements ZUNION under two functions:

  1. def zUnion: ZIO[..., Chunk[M]]
  2. def zUnionWithScores: ZIO[..., Chunk[MemberScore[M]]]

Similar to how zRange and zRangeWithScores were split due to different return types.

Also note that the test suites for each command are the same to zUnionStore, with the difference being the return values are checked individually.

@rfmejia rfmejia requested a review from a team as a code owner May 2, 2021 05:31
@mijicd mijicd merged commit 2c6c563 into zio:master May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Command ZUNION
3 participants