add zMScore #354
Merged
add zMScore #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this is totally fine as it reflects the Redis response. 👍 |
mijicd
reviewed
Apr 19, 2021
Comment on lines
1000
to
1001
| result <- zMScore(key, "Delhi", "Mumbai") | ||
| } yield assert(result)(equalTo(Chunk(Some(10d), Some(20d)))) |
There was a problem hiding this comment.
I'd include the "non-existing" value here.
mijicd
approved these changes
Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #351
Redis doc is
Array reply: list of scores or nil associated with the specified member values (a double precision floating point number), represented as strings.Chunk[Option[Double]]]is used, but I don't think it's the most suitable one. Does anyone have a better proposal?