Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LCS functionality #322

Merged
merged 6 commits into from
Apr 8, 2021
Merged

Add LCS functionality #322

merged 6 commits into from
Apr 8, 2021

Conversation

barthorre
Copy link
Contributor

@barthorre barthorre commented Mar 19, 2021 •
edited by mijicd
Loading

Closes #155

@barthorre barthorre requested a review from a team as a code owner March 19, 2021 11:42
@CLAassistant
Copy link

CLAassistant commented Mar 19, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@barthorre barthorre marked this pull request as draft March 19, 2021 11:51
mijicd
mijicd reviewed Mar 20, 2021
View reviewed changes
Copy link
Member

@mijicd mijicd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It goes in the right direction.

redis/src/main/scala/zio/redis/options/Strings.scala Outdated Show resolved Hide resolved
@mijicd mijicd mentioned this pull request Mar 20, 2021
Closed
@barthorre barthorre marked this pull request as ready for review March 22, 2021 14:05
@barthorre barthorre changed the title WIP: Add LCS functionality Add LCS functionality Mar 25, 2021
@mijicd mijicd merged commit c791efb into zio:master Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jxnu-liguobin jxnu-liguobin jxnu-liguobin left review comments

@anovakovic01 anovakovic01 anovakovic01 approved these changes

@mijicd mijicd mijicd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement remaining string commands
5 participants
@barthorre @CLAassistant @mijicd @anovakovic01 @jxnu-liguobin