Fixing Caliban integration & adding quill-caliban to build #44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caliban
productArgs
were not properly being handled, they were only being passed in on the top level.Also, in
flattenToPairs
, strings had""ExtraQuotes""
around them.Also added tests for many more cases with nested data.
Note that unless the Caliban schema is correctly matched to the output data, Circe deserialization will cause NPEs.
For example when the graphQL query:
And the following schema & query:
If the caliban integration messes up and does not pass any of the columns:
List("id", "age", "first", "last")
into thecolumns
variable being passed to the query.... let's say the last two columns are missing:columns:List("id", "age")
then the resulting data will look like:Instead of:
Circe will cause an NPE during deserialization. On the caliban side it will look like this:
If you are running it from ZIO-Http it will look like this: