Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to sbt-ci-release #326

Merged
merged 7 commits into from
Sep 17, 2023
Merged

Migrate to sbt-ci-release #326

merged 7 commits into from
Sep 17, 2023

Conversation

guizmaii
Copy link
Member

@guizmaii guizmaii commented Sep 4, 2023

No description provided.

@guizmaii guizmaii force-pushed the sbt-ci-release branch 3 times, most recently from b0b53d1 to c526735 Compare September 4, 2023 17:19
@guizmaii guizmaii marked this pull request as draft September 4, 2023 17:20
@guizmaii guizmaii changed the base branch from fix_release to master September 4, 2023 17:21
@guizmaii guizmaii force-pushed the sbt-ci-release branch 4 times, most recently from 2254a63 to ccc2f78 Compare September 5, 2023 07:10
@guizmaii guizmaii force-pushed the sbt-ci-release branch 5 times, most recently from 2008197 to 3cc66e2 Compare September 17, 2023 11:47
@guizmaii guizmaii marked this pull request as ready for review September 17, 2023 11:48
@guizmaii guizmaii mentioned this pull request Sep 17, 2023
Merged
juliano
juliano approved these changes Sep 17, 2023
View reviewed changes
Copy link
Collaborator

@juliano juliano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🥳

@guizmaii guizmaii merged commit 48ecf58 into master Sep 17, 2023
4 checks passed
@guizmaii guizmaii deleted the sbt-ci-release branch September 17, 2023 17:16
@tOverney
Copy link

@juliano does that mean that now #309 can be fixed? :)

@guizmaii
Copy link
Member Author

@juliano Do we want to wait to have sbt-ci-release in zio-quill too before making any new release?
I know that zio-protoquill depends on zio-quill. That could justify the additional wait but I don't know well enough about these projects nor their history nor the users' needs (like the one from @tOverney) to make a decision

@juliano
Copy link
Collaborator

juliano commented Sep 19, 2023

I believe it's the sensible thing to do in order to keep the consistency among the versions of zio-quill and zio-protoquill. However, it would be a possibility to release a super-minor-minor version only for protoquill in the meantime? This way the new features become available while we decide to do without affecting the main releases much. Wty?

@guizmaii
Copy link
Member Author

I'm good with this plan 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliano juliano juliano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guizmaii @tOverney @juliano