Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to latest version of ZIO (2.0.8) #242

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

williamareynolds
Copy link
Contributor

@williamareynolds williamareynolds commented Feb 9, 2023

Fixes #217

Problem

The ZIO version used is currently set at 2.0.2. Using any version of ZIO later than 2.0.2 results in problems with the ZIO Environment.

Solution

Upgrade the ZIO dependencies to the latest version.

Notes

Additional notes.

Checklist

  • Unit test all changes
  • Update README.md if applicable
  • Add [WIP] to the pull request title if it's work in progress
  • Squash commits that aren't meaningful changes

@getquill/maintainers

@williamareynolds williamareynolds changed the title Upgrade to latest version of ZIO (2.0.7) Upgrade to latest version of ZIO (2.0.8) Feb 9, 2023
@CLAassistant
Copy link

CLAassistant commented Feb 9, 2023

CLA assistant check
All committers have signed the CLA.

@adamgfraser
Copy link

@williamareynolds Can you please sign the CLA?

@williamareynolds
Copy link
Contributor Author

williamareynolds commented Feb 10, 2023

@williamareynolds Can you please sign the CLA?

Done! I still haven't been able to run unit tests locally. I'm travelling and my laptop only has 8GB of RAM. I'll have access to a desktop soon, but it looks like the tests will run in CI.

Edit:
I've updated to my correct email.

@williamareynolds
Copy link
Contributor Author

Alright, I think I've fixed the few little mistakes that were in here initially:

  • Version is set to 2.0.8 for zio dependencies
  • scala version is set to 3.2.2
  • ci workflow is updated to use correct scala version

@tdrozdowski
Copy link

I think you need to update this line in build/build.sh from -Xmx3g to:

export JVM_OPTS="-Dcommunity=false -Dquill.macro.log=false -Xms1024m -Xmx4g -Xss5m ${GC_OPTS}"

@williamareynolds
Copy link
Contributor Author

@getquill/maintainers I think this should be ready to go now. It's been passing locally for me even without the heap size changes, but I think this out to do it in CI.

@tdrozdowski
Copy link

Should we just update it to the freshly released 2.0.9?

@adamgfraser
Copy link

Any recent ZIO version will resolve this issue.

@williamareynolds
Copy link
Contributor Author

Should we just update it to the freshly released 2.0.9?

Any recent ZIO version will resolve this issue.

I'm okay with either, but I'm thinking it'd be better to just leave it at 2.0.8 to get something working again. We can let a scala-steward PR do the update to 2.0.9.

@deusaquilus deusaquilus merged commit cbfa499 into zio:master Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

quill-cassandra-zio example - Could not find Quill::Cassandra[+Literal] inside ZEnvironment
5 participants