Skip to content

Conversation

@vincenzopalazzo
Copy link
Collaborator

@vincenzopalazzo vincenzopalazzo commented Jul 13, 2022

There is a collision name between javascript ecosystem and graphql protocols, and this makes the usage of the enum very difficult.

In addition, this is the first of a sequence of PR that improve graphql protocols handling

This should fix #1162

In addition, this introduces the new field in the commit header proposed in #1179 (comment) but this is still working in progress

…ming

Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
@vincenzopalazzo vincenzopalazzo changed the title Macros/docs ws improve grapphql ws protocol docs Jul 13, 2022
@codecov
Copy link

codecov bot commented Jul 13, 2022

Codecov Report

Merging #1180 (42595e9) into main (0d8a3d0) will decrease coverage by 0.03%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##             main    #1180      +/-   ##
==========================================
- Coverage   59.72%   59.68%   -0.04%     
==========================================
  Files          41       41              
  Lines        1676     1677       +1     
==========================================
  Hits         1001     1001              
- Misses        675      676       +1     
Impacted Files Coverage Δ
...l/lib/src/links/websocket_link/websocket_link.dart 0.00% <ø> (ø)
...lib/src/links/websocket_link/websocket_client.dart 81.77% <87.50%> (-0.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d8a3d0...42595e9. Read the comment docs.

…aming

Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
@vincenzopalazzo vincenzopalazzo marked this pull request as ready for review July 13, 2022 19:18
@vincenzopalazzo
Copy link
Collaborator Author

Merging this for the moment, but I would like to keep this issue alive #1162

because there is somethings strange that happens when e we are working ws!

@vincenzopalazzo vincenzopalazzo merged commit fce8499 into main Jul 13, 2022
vincenzopalazzo added a commit that referenced this pull request Jul 22, 2022
improve grapphql ws protocol docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flutter 3.0.2 / graphql_flutter: 5.1.1-beta.3 | Subscription QueryResult returns null

3 participants