Add unit test to transaction record map #914
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ansactionRecordMap
fluidvanadium
previously approved these changes
Apr 10, 2024
Contributor
fluidvanadium
left a comment
fluidvanadium
left a comment
There was a problem hiding this comment.
tested and acknowledged!
this is a wicked mocker pattern. i love it
Contributor
|
what thingie? |
fluidvanadium
dismissed
their stale review
The merge-base changed after approval.
Member
Author
|
Hello, I have resolved conflicts and merged latest dev. |
fluidvanadium
previously requested changes
Apr 11, 2024
fluidvanadium
approved these changes
Apr 11, 2024
Contributor
fluidvanadium
left a comment
fluidvanadium
left a comment
There was a problem hiding this comment.
this is great! maybe i can duplicate these patterns for some more mocking stuff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on #911 #912 #913 so unless all of those pass review and merge this shouldn't.
Because the others require attention first, I have not yet requested review on this one.