Skip to content

Conversation

@dannasessha
Copy link
Contributor

Tested instructions of "Pre-requisites", using docker, with:
Debian 11.3
Debian 10.12
Ubuntu 22.04
Ubuntu 20.04
Ubuntu 18.04

I included Debian because zcash's official build support includes Debian, so I'd like to see at least a one distro supported setup for this repo, lightwalletd and zcash.

@dannasessha
Copy link
Contributor Author

Fixes #3 .

@dannasessha dannasessha requested a review from zancas June 24, 2022 23:45
@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2022

Codecov Report

Merging #5 (85678a2) into dev (8c49cae) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev       #5   +/-   ##
=======================================
  Coverage   59.05%   59.05%           
=======================================
  Files          31       31           
  Lines        5729     5729           
=======================================
  Hits         3383     3383           
  Misses       2346     2346           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c49cae...85678a2. Read the comment docs.

skyl
skyl previously approved these changes Jun 25, 2022
Copy link
Contributor

@skyl skyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@zancas
Copy link
Member

zancas commented Jun 25, 2022

We need to remove references to a light or lite wallet. That's not what this repo is.

Copy link
Member

@zancas zancas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move the lightwallet section into a zingo-cli-specific README.

@dannasessha dannasessha mentioned this pull request Jul 1, 2022
@dannasessha dannasessha closed this Jul 2, 2022
zancas added a commit that referenced this pull request Apr 28, 2023
Darksidewalletd test improvements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants