-
Notifications
You must be signed in to change notification settings - Fork 35
WIP: zingo-cli regtest mode invocation #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #26 +/- ##
==========================================
- Coverage 58.22% 57.20% -1.02%
==========================================
Files 30 30
Lines 5838 5942 +104
==========================================
Hits 3399 3399
- Misses 2439 2543 +104
Continue to review full report at Codecov.
|
|
In conversation: "the regtest specific information should go in a README.md inside the regtest directory" |
|
In further conversation "dump all binaries in |
|
I now don't like the base ...now there's I'd like to change that to something unique. Also, I know regtest is the feature, but it strikes me that with |
|
Still also: |
This is done, along with some other stuff too. I'd say all the core functions are in place now, but the code should be cleaned up and maybe minimized, as well as probably moved to another mod. |
|
This is coming along!! Please add logic to handle graceful shut-down of spawned threads. When the user instructs the
|
zancas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a significant, functional piece of work. It should be merged.
|
I removed the DRAFT label. There are next steps, but this is a coherent chunk, and should be landed. |
zancas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a coherent chunk.
Working toward #17 - For now this is just a README update.
If you'd like to see the abstract path setup or specific naming of what I'm about to build into the tool this is a good moment to comment.
Problem:
I couldn't get the
zcashdto write to thedebug.logfile at all. I saw this issue on zcash's page, which is listed as a 'good first issue' but it's a bit beyond me, at least at a glance, wasn't sure if it could be a lead on this issue but I'd like another dev to confirm this isn't working for them, or point out what I've done wrong.Maybe there's other logging or metrics you'd like to capture @zancas ? I was thinking about trying to timestamp log files, for example.
I'm concerned about these kinds of issues too, so I'd like to have those kinds of updates(or reassurance I shouldn't worry!) in place before moving around more Rust.