Skip to content

Conversation

@zancas
Copy link
Member

@zancas zancas commented Jun 30, 2022

  • async and tokio runtime are factored into a cli specific trait
  • consts are moved to config
  • get_initial_state migrates from config -> lightclient

* async and tokio runtime are factored into a cli specific trait
* consts are moved to config
@zancas zancas requested a review from AloeareV June 30, 2022 05:45
@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2022

Codecov Report

Merging #20 (0bc3a60) into dev (5376dee) will decrease coverage by 0.05%.
The diff coverage is 25.58%.

@@            Coverage Diff             @@
##              dev      #20      +/-   ##
==========================================
- Coverage   58.28%   58.22%   -0.06%     
==========================================
  Files          31       31              
  Lines        5832     5838       +6     
==========================================
  Hits         3399     3399              
- Misses       2433     2439       +6     
Impacted Files Coverage Δ
cli/src/lib.rs 0.00% <0.00%> (ø)
cli/src/main.rs 0.00% <ø> (ø)
config/src/lib.rs 40.29% <ø> (ø)
lib/src/wallet/keys.rs 45.86% <ø> (ø)
lib/src/lightclient.rs 60.68% <62.50%> (-0.02%) ⬇️
lib/src/lightclient/lightclient_config.rs 30.69% <100.00%> (+1.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5376dee...0bc3a60. Read the comment docs.

Copy link
Contributor

@AloeareV AloeareV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good!

@AloeareV AloeareV merged commit ddf8261 into zingolabs:dev Jun 30, 2022
@zancas zancas deleted the trait_izeasync branch October 27, 2022 21:01
zancas pushed a commit that referenced this pull request Nov 29, 2022
provide insight into note distribution
dorianvp pushed a commit that referenced this pull request Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants