-
Notifications
You must be signed in to change notification settings - Fork 35
Even morchard #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… librustzcash/orchard version mismatch
…o blind removal of price. Need to restore partially
They aren't saved in the wallet yet, nor are they detected on rescan. If zingo-cli is running when it recieves an orchard transaction, it will print the memo to the console
… along those lines
Codecov Report
@@ Coverage Diff @@
## dev #2 +/- ##
==========================================
- Coverage 59.05% 58.51% -0.54%
==========================================
Files 31 31
Lines 5729 5809 +80
==========================================
+ Hits 3383 3399 +16
- Misses 2346 2410 +64
Continue to review full report at Codecov.
|
zancas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a preliminary review. I will need to rereview (at least once) before I can approve.
We have orchard note decryption!!
It doesn't happen on sync/resync, only if an (orchard) action is received while zingo-cli is running in interactive mode, and all it does is print the memo to the terminal, but it's enough proof that we're able to parse orchard transactions for me to move on to focusing on actually getting the wallet side of this working. Writing orchard keys into the wallet (they currently need to be regenerated after startup each time), writing received orchard data down, etc.