Skip to content

Conversation

@AloeareV
Copy link
Contributor

@AloeareV AloeareV commented Jun 24, 2022

We have orchard note decryption!!
It doesn't happen on sync/resync, only if an (orchard) action is received while zingo-cli is running in interactive mode, and all it does is print the memo to the terminal, but it's enough proof that we're able to parse orchard transactions for me to move on to focusing on actually getting the wallet side of this working. Writing orchard keys into the wallet (they currently need to be regenerated after startup each time), writing received orchard data down, etc.

@AloeareV AloeareV requested a review from zancas June 24, 2022 13:49
@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2022

Codecov Report

Merging #2 (f34d7b8) into dev (8bcad10) will decrease coverage by 0.53%.
The diff coverage is 52.07%.

@@            Coverage Diff             @@
##              dev       #2      +/-   ##
==========================================
- Coverage   59.05%   58.51%   -0.54%     
==========================================
  Files          31       31              
  Lines        5729     5809      +80     
==========================================
+ Hits         3383     3399      +16     
- Misses       2346     2410      +64     
Impacted Files Coverage Δ
lib/src/grpc_connector.rs 78.50% <0.00%> (ø)
lib/src/wallet/keys/orchard.rs 18.75% <11.11%> (-3.75%) ⬇️
lib/src/blaze/block_witness_data.rs 71.42% <20.00%> (-0.30%) ⬇️
lib/src/compact_formats.rs 56.75% <28.57%> (-23.89%) ⬇️
lib/src/wallet/keys.rs 46.08% <28.57%> (-0.56%) ⬇️
lib/src/blaze/trial_decryptions.rs 69.60% <34.37%> (-11.41%) ⬇️
lib/src/wallet.rs 68.38% <42.85%> (+0.09%) ⬆️
lib/src/blaze/fetch_full_transaction.rs 94.20% <57.14%> (-4.52%) ⬇️
lib/src/wallet/data.rs 57.94% <63.63%> (-0.19%) ⬇️
lib/src/wallet/transactions.rs 78.60% <72.41%> (-1.91%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bcad10...f34d7b8. Read the comment docs.

Copy link
Member

@zancas zancas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a preliminary review. I will need to rereview (at least once) before I can approve.

@AloeareV AloeareV requested a review from zancas June 27, 2022 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants