Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve coding standard config #93

Merged
merged 1 commit into from
Aug 21, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions ecs.php
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,11 @@
$parameters->set(
Option::PATHS,
[
'config',
'src',
'tests',
'ecs.php',
'rector.php',
__DIR__ . '/config',
__DIR__ . '/src',
__DIR__ . '/tests',
__DIR__ . '/ecs.php',
__DIR__ . '/rector.php',
]
);
};
12 changes: 6 additions & 6 deletions rector.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@
use Rector\PHPStan\Rector\Cast\RecastingRemovalRector;
use Rector\PHPUnit\Rector\Class_\AddSeeTestAnnotationRector;
use Rector\Set\ValueObject\SetList;
use Rector\SOLID\Rector\Class_\ChangeReadOnlyVariableWithDefaultValueToConstantRector;
use Rector\SOLID\Rector\Class_\FinalizeClassesWithoutChildrenRector;
use Rector\SOLID\Rector\Class_\RepeatedLiteralToClassConstantRector;
use Rector\SOLID\Rector\ClassMethod\ChangeReadOnlyVariableWithDefaultValueToConstantRector;
use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;

return static function (ContainerConfigurator $containerConfigurator): void {
Expand Down Expand Up @@ -44,11 +44,11 @@
$parameters->set(
Option::PATHS,
[
'config',
'src',
'tests',
'ecs.php',
'rector.php',
__DIR__ . '/config',
__DIR__ . '/src',
__DIR__ . '/tests',
__DIR__ . '/ecs.php',
__DIR__ . '/rector.php',
]
);
};
4 changes: 4 additions & 0 deletions tests/IntegrationTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,10 @@ public function testAllDriversHasDefaultConfig(): void
->keys()
->filter(
function ($name) {
if (! class_exists($name)) {
return false;
}

$reflectionClass = new ReflectionClass($name);
if (! $reflectionClass->isSubclassOf(GatewayInterface::class)) {
return false;
Expand Down