Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default arguments for routeNotificationForSms #84

Merged
merged 1 commit into from
Aug 17, 2020

Conversation

zingimmick
Copy link
Owner

No description provided.

@codecov
Copy link

codecov bot commented Aug 17, 2020

Codecov Report

Merging #84 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #84   +/-   ##
=========================================
  Coverage     98.58%   98.58%           
  Complexity       75       75           
=========================================
  Files            17       17           
  Lines           212      212           
=========================================
  Hits            209      209           
  Misses            3        3           
Impacted Files Coverage Δ Complexity Δ
src/SmsNumber.php 66.66% <100.00%> (ø) 1.00 <1.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54a6805...79a37ad. Read the comment docs.

@zingimmick zingimmick changed the title Fix default arguments for routenotificationforsms Fix default arguments for routeNotificationForSms Aug 17, 2020
@sonarcloud
Copy link

sonarcloud bot commented Aug 17, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codeclimate
Copy link

codeclimate bot commented Aug 17, 2020

Code Climate has analyzed commit 79a37ad and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 92.6% (-7.4% change).

View more on Code Climate.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ShiftLeft Scan Summary

Tool Critical High Medium Low Status
ShiftLeft Security audit for PHP 0 0 5 0
ShiftLeft Security taint analysis for PHP 0 0 0 0
ShiftLeft Security audit for Infrastructure 0 0 0 0

Recommendation

Looks good ✔️

@zingimmick zingimmick merged commit c70c749 into master Aug 17, 2020
@zingimmick zingimmick deleted the fix-default-arguments branch August 17, 2020 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant