-
Notifications
You must be signed in to change notification settings - Fork 11
Add new InterIntraMD Calculator to IPSuite #388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
MrJulEnergy
wants to merge
58
commits into
optionalForces
Choose a base branch
from
InterIntraNode
base: optionalForces
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
* switched xtb-python with tblite * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Do you think it might be possible to implement this as a modifier IPSuite/ipsuite/calculators/ase_md.py Lines 544 to 545 in b7ff045
to allow for the usage of all other parts of the Or something like an
|
* ipsuite uv setup * fix zntrack update * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * update pre-commit hook * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * update install * reduce version, add keywords, test on 3.11 * remove version check --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* evaluate checsk in outer loop * added safe sampling node * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * suggested changes * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * remove comment --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
for more information, see https://pre-commit.ci
Fix pre-commit.ci remarks
for more information, see https://pre-commit.ci
Add a Bond Length Constraint Node
change typehint in langevin to float
* migrate to laufband for parallel CP2k runs * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * use `laufband` for cp2k to allow parallel execution via paraffin * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* add `AnalyseStructureMeanForce` * update plotting * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* introduce `GenericASECalculator` and `ApplyCalculator` * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * update abstraction * add `dump_rate` to apply * add deprecation warnings * introduce CP2KModel * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * working implementation * update CP2KModel * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * add `TBLiteModel` * add `ORCAModel` * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix typos * add docs * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * use zntrack relase version * add MACEMP model as well as ApplyCalculator test using it. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix line length * move and rename `GenericASEModel` * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * address comments --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
updates: - [github.com/astral-sh/ruff-pre-commit: v0.11.2 → v0.11.9](astral-sh/ruff-pre-commit@v0.11.2...v0.11.9) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* change python version requirements in pyproject * add PlumedCalculator to init files * draft basic plumed node and work on atoms dependency for the ase calc * kind of working now * Change params path to deps path * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix ruff problems * draft docstring * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix the overwriting of model results when using plumed * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * somehow a duplicate line keeps showing up and needs to be removed... * i seem to have missed a few things while merging * add a plumed example * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix minor mistakes * fix spelling * update plumded model * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * remove poetry references * refactor plumed calc * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * move files to output directory * add docstrings * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * inheret from ipsbase * remove plumed action imports * fix mutable defaults * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * update docs * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * update units * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix units * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * lint * final lint --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Fabian Zills <46721498+PythonFZ@users.noreply.github.com> Co-authored-by: Fabian Zills <fzills@icp.uni-stuttgart.de> Co-authored-by: PythonFZ <fabian.zills@web.de>
* small asemd refactoring to catch errors in the calculator * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix pbar * try .. except handling for plumed * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * type hints * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * add `time_step` and `temperature` * move checks to `dynamics` module * refactor `md`, `transformations`, `constraints` * refactor ASEMD * finish refactor of `ASEMD` * fix import path * account for missing laufband file * update tests * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* use `frames_path` * bump znh5md version * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* introduced modifier step offset and test * change default status of checks * updated debugcheck * fix reset test * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * check initialization in dynamics * add `modifier_step_offset` * ignore C901 * presumably fix the test * fix 0 / 1 indexing, add and adapt tests. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: Moritz Schaefer <moritz.schaefer@pm.me> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Fabian Zills <fzills@icp.uni-stuttgart.de>
* custom cp2k calculator * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * add cp2koutput tes * update cp2k model parser * include pint, exclude cp2k-input-tools * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * precommit and keep legacy code * update packages * address comments * lint * bump Laufband * review * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * bugfix --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* re-introduce `TorchDFTD3` * add `implemented_properties` to always compute forces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am proposing the new MD node
InterIntraMD
, which enables the reweighing of rotational, translational and vibrational forces acting on each molecule.