temporal fix: crystal-handle colourisable mounts for OTCR

[Paco161315]

I'm sure you have met this problem in otcr where color mounts ends by crashing otcr player screen when playing with mixed cipsoft and otcr clients. Well, this is a temporal solution that sets color 0 in mounts, this way you don't have to disable mounts in the xml and you can enable mixed cipsoft and otcr in same server.

This is a temporal fix while otcr guys handle the color mounts, I know it's a lil fixed already but if you change color as cip client player in front of a otcr player you will go totally invisible, this script will prevent this problem while a solution is created.

This doesn't has to be merged if tryller doesn't want to, it's just a code I'm sharing with you guys so you can play without problems. I would make it configurable but it makes no sense because otcr may be updated soon.

Works for both android and windows otcr clients, you can try with the clients of mine, just change the ip and connect to your server:

Windows
https://tibiatales.com/otclient.zip

Android
https://tibiatales.com/androidotclient.apk

NOTE: YOU CANNOT DO THIS OTC SIDE BECAUSE FUNCTION ISN'T PROPERLY CREATED IN SOURCE YET

[omarcopires]

Kudos for the creativity, but my CPU started crying just reading this code. Running an onThink event every 250ms that loops through the server's entire player list just to fix a purely visual client bug is like burning down your car because the ashtray is full.The OTC side might indeed be broken, but fixing it by frying the server-side is definitely not the way to go. If anyone puts this into production with more than 5 players online, the lag will end up making everyone invisible anyway.

[Mateuzkl]

Running onThink every 250 ms and iterating through all online players is not a good solution. It creates constant CPU and Lua GC overhead and may trigger unnecessary outfit broadcasts. This is not a direct memory leak, but it scales poorly. The fix should be event-based or handled in ProtocolGame only when the outfit changes.

[Paco161315]

Running onThink every 250 ms and iterating through all online players is not a good solution. It creates constant CPU and Lua GC overhead and may trigger unnecessary outfit broadcasts. This is not a direct memory leak, but it scales poorly. The fix should be event-based or handled in ProtocolGame only when the outfit changes.

Alright man will do! I only play with my friends in my server. So I never had an issue we are very few people, but you are right!

[Paco161315]

Running onThink every 250 ms and iterating through all online players is not a good solution. It creates constant CPU and Lua GC overhead and may trigger unnecessary outfit broadcasts. This is not a direct memory leak, but it scales poorly. The fix should be event-based or handled in ProtocolGame only when the outfit changes.

That's absolutely right man, will send fix

[Paco161315]

I just updated code, I didn't want to c++ it because this is only a temporal measure until otc gets updated. Don't merge this PR but leave it here for everyone to see and combine clients if they desire so! - There is now less punishment to your resources.

[jprzimba]

I could be mistaken, but I believe this needs to be fixed directly in the OTC, right?

[Paco161315]

I could be mistaken, but I believe this needs to be fixed directly in the OTC, right?

Yeah man, you can use this while they fix the otc