fix: Add clearArea handler and Lua binding (Map Change Clear Cache) - #785
Open
jprzimba wants to merge 2 commits into
Open
fix: Add clearArea handler and Lua binding (Map Change Clear Cache)#785jprzimba wants to merge 2 commits into
jprzimba wants to merge 2 commits into
Conversation
Contributor
|
Testei o ebb and flow do Soul War com múltiplas trocas de mapa e tudo funcionando perfeitamente. Nenhum problema identificado até o momento. ✅ |
Contributor
|
This PR is stale because it has been open 45 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a possible solution for map switching on the server, especially on the Soul War map where switching happens frequently.
It was discovered that ebb and flow is a major memory leak.
With each loadMap, setBasicTile only overwrites tiles that exist in the new OTBM. Tiles that were in the previous map but are not in the new one remain in the Floor cache (shared_ptr), accumulating. After many swaps, thousands of orphaned shared_ptr pointing to old BasicTile objects are retained.
NOTE: This isn't 100% yet, but we're running tests to see how it behaves during the time the server is online. This PR is subject to change.