Stop listening on onTouchCancel. #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android default browsers (not chrome) triggers this when scrolling which results in positive-false onTouchTap events.
|
Thank you for your pull request, I don't always have an Android devise laying around. So I can't test this at this moment. I'm keeping this open until I confirmed the issue and your fix. |
s0meone
added a commit
that referenced
this pull request
Feb 6, 2015
Stop listening on onTouchCancel.
|
This will probably fix #8 as well. |
|
can we now publish an updated version on npm ? |
|
Sorry, I did make a release but forgot to push the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Im using this event for a little app, and noticed that on the default android browser (at least the ones of <= 4.4.4) generates falses onTouchCancel events when scrolling.
When you touchStart and move the finger, onTouchCancel is getting triggered (with the finger still pressed).
This plugin treat it as a isEndish() so its emitting the onTouchTap event, making the app not very useful.
Probably not everyone loves the default chrome browser, but its the default, and is what been used when you phongap/cordova-ize you app.
Thanks!!