Skip to content

Finish Korean(ko) translation #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 19, 2017
Merged

Finish Korean(ko) translation #71

merged 2 commits into from
Aug 19, 2017

Conversation

yuhwan
Copy link
Contributor

@yuhwan yuhwan commented Aug 19, 2017

This pull request is about translation of the learn-regex contents into Korean (ko).

Rather than generating the png file by changing the svg file, I list down some translations for sentences used in theregexp-en.png image to keep consistency of the regex-x.png image files.

english korean
Start of the line 줄의 시작
3 to 15 characters long 3이상 15이하 길이의 문자
Letters, numbers, underscores, hypens 문자, 숫자, 밑줄, 하이픈
End of the line 줄의 끝

@yuhwan yuhwan changed the title Add Korean(ko) ReadMe Finish Korean(ko) translatio Aug 19, 2017
@yuhwan yuhwan changed the title Finish Korean(ko) translatio Finish Korean(ko) translation Aug 19, 2017
Copy link
Contributor

@eamanu eamanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add in whole Translation section the link to README-ko.md

@yuhwan
Copy link
Contributor Author

yuhwan commented Aug 19, 2017

@eamanu I just added the link to README-ko.md in the whole Translation sections.

@eamanu
Copy link
Contributor

eamanu commented Aug 19, 2017

Great! ready for merge

@ziishaned ziishaned merged commit 94e2626 into ziishaned:master Aug 19, 2017
atefBB pushed a commit to atefBB/learn-regex that referenced this pull request Aug 20, 2017
* Create Korean ReadMe

* Add link to README-ko.md
@yuhwan yuhwan deleted the translation-korean branch August 20, 2017 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants