Adds a 'format to camelCase' codeaction for function names #679
Conversation
Techatrix
left a comment
Techatrix
left a comment
There was a problem hiding this comment.
Thanks for you PR! It's great to see more code actions getting integrated. There are "a few" issues though.
If you are interested you can also add code actions for Type functions should be PascalCase or A ./ is not needed in imports.
src/code_actions.zig
Outdated
| try actions.append(builder.arena.allocator(), .{ | ||
| .title = "discard value", | ||
| .kind = .SourceFixAll, | ||
| .kind = .QuickFix, |
There was a problem hiding this comment.
this should be keep at SourceFixAll
There was a problem hiding this comment.
this has to be resolved before i can approve
There was a problem hiding this comment.
sorry, i'm not too familiar with git and i missed this. fixed
There was a problem hiding this comment.
I think your latest commit touched the wrong place.
Set this location https://github.com/NuclearPhone/zls/blob/39ea5869a377eeec71fe333f2ee264fac7cf2bbb/src/code_actions.zig#L85 to .QuickFix.
And set this location https://github.com/NuclearPhone/zls/blob/39ea5869a377eeec71fe333f2ee264fac7cf2bbb/src/code_actions.zig#L176 to .SourceFixAll.
|
Thanks for the feedback; I'll get to fixing my error-ridden code. In the future i'll pay more attention to proof-reading. |
3 participants
Does as the title says, this PR adds a code action that reformats non-camelCase function names to be camelCase.