Skip to content

update zig #2413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
antlilja wants to merge 4 commits into from
Closed

update zig #2413

antlilja wants to merge 4 commits into from

Conversation

@antlilja
Copy link
Contributor

@antlilja antlilja commented Jul 19, 2025

Depends on zigtools/lsp-kit#23

@antlilja antlilja marked this pull request as ready for review July 19, 2025 15:53
antlilja added 2 commits July 19, 2025 18:12
@antlilja
update lsp-kit
42717bc
@antlilja
update flake.lock
44f3429 
• Updated input 'nixpkgs':
    'github:NixOS/nixpkgs/10e687235226880ed5e9f33f1ffa71fe60f2638a?narHash=sha256-3MxxkU8ZXMHXcbFz7UE4M6qnIPTYGcE/7EMqlZNnVDE%3D' (2025-07-10)
  → 'github:NixOS/nixpkgs/32a4e87942101f1c9f9865e04dc3ddb175f5f32e?narHash=sha256-f3pO%2B9lg66mV7IMmmIqG4PL3223TYMlnlw%2Bpnpelbss%3D' (2025-07-15)
• Updated input 'zig-overlay':
    'github:mitchellh/zig-overlay/ef606ab86e0ac5aa4c6105ed4c446628989028a6?narHash=sha256-fdhSY2g5O05QAjlxgh6aZYGyghQlGslPA/f6aPed1c0%3D' (2025-07-12)
  → 'github:mitchellh/zig-overlay/6b563a69413e07b6009be6b42d9d46cee2dd9ad3?narHash=sha256-6NyOS9iU6YtUbUWWVsGFuDthC4gz2UFm7pz6G5xy5OY%3D' (2025-07-19)
@Techatrix
Copy link
Member

Techatrix commented Jul 19, 2025 •
edited
Loading

There are some issues with this PR that would need to be addressed to be merged:

  • do not let error.WriteFailed traverse through the entire program. The error should be catched wherever the underlying writer has been created.
  • Do not use adaptToNewApi when you can use the new API directly
  • semantic tokens for the new asm clobbers are missing
  • Calling tree.extraData(extra_index, Node.Asm) on a .asm_legacy node is incorrect (here)
  • tree.asmLegacy(node) should be ast.asmLegacy(tree, node) (here)

I can save you the effort of addressing these issues as I had already made these changes locally. See #2415

@Techatrix Techatrix closed this Jul 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@antlilja @Techatrix