Skip to content

Conversation

Techatrix
Copy link
Member

Before

Screenshot from 2024-03-07 14-47-58

After

Screenshot from 2024-03-07 14-48-13

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 96.77419% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 78.51%. Comparing base (300770c) to head (a0f4666).

Files Patch % Lines
src/analysis.zig 92.68% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1822      +/-   ##
==========================================
+ Coverage   78.40%   78.51%   +0.11%     
==========================================
  Files          34       34              
  Lines       10575    10623      +48     
==========================================
+ Hits         8291     8341      +50     
+ Misses       2284     2282       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Techatrix
Copy link
Member Author

Is the hint even necessary here? it is duplicate information, therefore noise

I guess this could be considered another example where #1526 could apply.

But also, my example is only there to illustrate the changes of this PR.
No one in their right mind would write code like this. I hope...

@Techatrix Techatrix merged commit b9de89c into master Mar 12, 2024
@Techatrix Techatrix deleted the techatrix/truncate-type-hint-decl branch March 13, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant