-
-
Notifications
You must be signed in to change notification settings - Fork 398
autofix: discard captures + some multi for loop support #1202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
leecannon
merged 3 commits into
zigtools:master
from
travisstaloch:issue-689-discard-caps
May 27, 2023
Merged
autofix: discard captures + some multi for loop support #1202
leecannon
merged 3 commits into
zigtools:master
from
travisstaloch:issue-689-discard-caps
May 27, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this patch makes autofix add discards for unused loop and switch case captures which have curlies. it prevents adding duplicate 'remove capture' actions by checking previous action ranges. it removes special casing of index captures now that multi for loops have arrived. * make getCaptureLoc() return only single Loc * remove CaptureLocs struct which is no longer used * add DiagnosticKind.@"switch tag capture" to handle 'inline else => |x, tag|' discards * add test "getCaptureLoc"
This was referenced May 27, 2023
Contributor
Author
|
addresses #689 tested with test {
for (0..10, 0..10, 0..10) |i, j, k| {}
switch (union(enum) {}{}) {
inline .a => |cap, tag| {},
}
if (null) |x| {}
if (null) |v| {} else |e| {}
_ = null catch |e| {};
}this becomes: test {
for (0..10, 0..10, 0..10) |i, j, k| {
_ = k;
_ = j;
_ = i;
}
switch (union(enum) {}{}) {
inline .a => |cap, tag| {
_ = tag;
_ = cap;
},
}
if (null) |x| {
_ = x;
}
if (null) |v| {
_ = v;
} else |e| {
_ = e;
}
_ = null catch |e| {
_ = e;
};
} |
* reject missing opening '|' * reject capture group of only spaces * add tests for these cases
Member
|
This looks good 👍 |
leecannon
approved these changes
May 27, 2023
Contributor
Author
|
interesting note: just tested a release-fast build and the discard order is reversed back to source order. test {
for (0..10, 0..10, 0..10) |i, j, k| {
_ = i;
_ = j;
_ = k;
}
...glad to see they're in source order. not sure why they were reversed in the debug build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this patch makes autofix add discards for unused loop and switch case captures which have curlies. it prevents adding duplicate 'remove capture' actions by checking previous action ranges.
it removes special casing of index captures now that multi for loops have arrived.