Build failed with `zig` 0.16.0-dev.2504+4c35d53b9

[arngaillard]

Zig Version

0.16.0-dev.2504+4c35d53b9

ZLS Version

a27f8dc

Client / Code Editor / Extensions

No response

Steps to Reproduce and Observed Behavior

Apologies for opening yet another issue but it seems the build still fails with the latest zig.

Expected Behavior

I expect to be able to build zls with the latest zig

Attach ZLS log output

zig build -Doptimize=ReleaseSafe
install
└─ install zls
   └─ compile exe zls ReleaseSafe native 1 errors
/home/arnaud/.cache/zig/p/lsp_kit-0.1.0-bi_PL94yDABlKrIbUTtVALYWLeFt6XAzHS6R12Tp83_Z/src/lsp.zig:1247:33: error: root source file struct 'Thread' has no member named 'Mutex'
    MutexType: type = std.Thread.Mutex,
                      ~~~~~~~~~~^~~~~~
/home/arnaud/dev/zig/ziglang/build/stage3/lib/zig/std/Thread.zig:1:1: note: struct declared here
//! This struct represents a kernel thread.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
referenced by:
    ThreadSafeTransportConfig: /home/arnaud/.cache/zig/p/lsp_kit-0.1.0-bi_PL94yDABlKrIbUTtVALYWLeFt6XAzHS6R12Tp83_Z/src/lsp.zig:1242:39
    ThreadSafeTransport: /home/arnaud/.cache/zig/p/lsp_kit-0.1.0-bi_PL94yDABlKrIbUTtVALYWLeFt6XAzHS6R12Tp83_Z/src/lsp.zig:1251:36
    6 reference(s) hidden; use '-freference-trace=8' to see all references
error: 1 compilation errors
failed command: /home/arnaud/dev/zig/ziglang/build/stage3/bin/zig build-exe -OReleaseSafe --dep exe_options --dep known-folders --dep tracy --dep zls -Mroot=/home/arnaud/dev/zig/zls/src/main.zig -Mexe_options=.zig-cache/c/5b53cebe1b24419b417ac4247c9dc033/options.zig -OReleaseSafe -Mknown-folders=/home/arnaud/.cache/zig/p/known_folders-0.0.0-Fy-PJqHJAAB43zDJmOdlr3nViu69IFI9pNFt7hkHjKk4/known-folders.zig -fno-sanitize-c -OReleaseSafe --dep options -Mtracy=/home/arnaud/dev/zig/zls/src/tracy.zig -OReleaseSafe --dep diffz --dep lsp --dep tracy --dep build_options --dep version_data -Mzls=/home/arnaud/dev/zig/zls/src/zls.zig -Moptions=.zig-cache/c/bb0dffb13b4c35a61af55ff4a8bdc191/options.zig -OReleaseSafe -Mdiffz=/home/arnaud/.cache/zig/p/diffz-0.0.1-G2tlISLPAQDzXkUIRWWUfdgIsIb1dAyVwRPXMt5kRpui/DiffMatchPatch.zig -OReleaseSafe --dep parser --dep types -Mlsp=/home/arnaud/.cache/zig/p/lsp_kit-0.1.0-bi_PL94yDABlKrIbUTtVALYWLeFt6XAzHS6R12Tp83_Z/src/lsp.zig -Mbuild_options=.zig-cache/c/6449c8b4489ab1c8a7eb5e615ee9afcc/options.zig -Mversion_data=.zig-cache/o/1d28393f6f2301e2cd73f14d5150b230/version_data.zig -OReleaseSafe -Mparser=/home/arnaud/.cache/zig/p/lsp_kit-0.1.0-bi_PL94yDABlKrIbUTtVALYWLeFt6XAzHS6R12Tp83_Z/src/parser.zig -OReleaseSafe --dep parser -Mtypes=.zig-cache/o/6d3eb78f94d5dd44b8af135b1e979983/lsp_types.zig --cache-dir .zig-cache --global-cache-dir /home/arnaud/.cache/zig --name zls --zig-lib-dir /home/arnaud/dev/zig/ziglang/build/stage3/lib/zig/ --listen=-

Build Summary: 7/10 steps succeeded (1 failed)
install transitive failure
└─ install zls transitive failure
   └─ compile exe zls ReleaseSafe native 1 errors

error: the following build command failed with exit code 1:
.zig-cache/o/eb3e8bf25244f070c87b54a9293cec93/build /home/arnaud/dev/zig/ziglang/build/stage3/bin/zig /home/arnaud/dev/zig/ziglang/build/stage3/lib/zig /home/arnaud/dev/zig/zls .zig-cache /home/arnaud/.cache/zig --seed 0xb6409857 -Z2ac44ef1300f2083 -Doptimize=ReleaseSafe

[Techatrix]

fixed by #2596

[sagehane]

I don't think the flake lockfile was updated? I'm hitting this:

$ nix build
error: Cannot build '/nix/store/2a54mjg9wfhp3ci246r15b3gz0cjzsqs-zls.drv'.
       Reason: builder failed with exit code 2.
       Output paths:
         /nix/store/s4cs38vdgly27slnnmhpjs5jwiv2if4x-zls
       Last 20 log lines:
       > Running phase: unpackPhase
       > unpacking source archive /nix/store/xabbdmrz3klq0xnmq6pny9mrnk2zp57x-source
       > source root is source
       > Running phase: patchPhase
       > Running phase: updateAutotoolsGnuConfigScriptsPhase
       > Running phase: configurePhase
       > Running phase: buildPhase
       > build.zig:705:9: error: Your Zig version does not meet the minimum build requirement:
       >                           required Zig version: 0.16.0-dev.2510+bcb5218a2 (or greater)
       >                           actual   Zig version: 0.16.0-dev.2471+e9eadee00
       >
       >                         You can take one of the following actions to resolve this issue:
       >                           - Download the latest nightly of Zig (https://ziglang.org/download/)
       >                           - Compile an older version of ZLS that is compatible with your Zig version
       >         @compileError(message);
       >         ^~~~~~~~~~~~~~~~~~~~~~
       > referenced by:
       >     build: build.zig:34:18
       >     runBuild__anon_32711: /nix/store/kmy5g89jryhqhaqm7imw0qfzcdy3gi2n-zig-0.16.0-dev.2471+e9eadee00/lib/std/Build.zig:2257:50
       >     6 reference(s) hidden; use '-freference-trace=8' to see all references
       For full logs, run:
         nix log /nix/store/2a54mjg9wfhp3ci246r15b3gz0cjzsqs-zls.drv

[Techatrix]

I pushed a8c5850 to fix this.