handle response 0x8012 #113
Conversation
|
I know I should handle this message in the application, but I don't know what it's for, I'm looking into it right now EDIT: Ok I think from fairecasoimeme/ZiGate#350 we can safely discard it Second Edit: I have a bunch of 0x9999 too, is this from here: APP_ZCL_cbEndpointCallback https://github.com/fairecasoimeme/ZiGate/blob/e54cabc22a49f33121e6e9c7cbecf779203b8ec7/ModuleRadio/Firmware/src/ZiGate/Source/ZigbeeNodeControlBridge/app_zcl_event_handler.c#L434 and can I safely discard them too or do we need to handle them differently? |
The PR is closed because they fork the project and cherry pick (when tested in their projects) the commit into zigpy-zigate |
|
#104 |
|
I'm not really fond of using a fork, when there is no official communication from the maintainers of this repository to do so. Is this repository unmaintained? @doudz If so, I can make a pull request to change the README of this repository to explain that we should move to the https://github.com/zigbeefordomoticz/zigpy-zigate fork? |
|
I just have no time to work on this repo but PR are welcome :) |
zigpy_zigate/zigbee/application.py
Outdated
| @@ -153,6 +155,8 @@ def zigate_callback_handler(self, msg, response, lqi): | |||
| elif msg == 0x8702: # APS Data confirm Fail | |||
| LOGGER.debug('APS Data confirm Fail %s %s', response[4], response[0]) | |||
| self._handle_frame_failure(response[4], response[0]) | |||
| elif msg == 0x9999: # ZCL event | |||
| LOGGER.debug('ZCL application started %s', response[0]) | |||
There was a problem hiding this comment.
This debug message is not really understandable in my opinion, maybe something like "Extended error code %s" is better ?
There was a problem hiding this comment.
I did not even knew it was an error, I thought it was a normal application response.
I changed it
There was a problem hiding this comment.
Logging an Error as a Debug looks strange
There was a problem hiding this comment.
Do you have somewhere a documentation that could help me understand this 0x9999 event and what it means?
I have a bunch of them at each restart of home-assistant, I thought it was normal.
Is it ok if I raise this to a warning level @pipiche38?
Open source in a nutshell! :) |
|
@MichaelBitard , for the documentation I would refer to https://www.nxp.com/docs/en/user-guide/JN-UG-3113.pdf In short these are Errors code trigger by the stack itself, which comes to provide more details on an error happening. For instance Extended error code 0x80, 0x81, 0x82, 0x83 are showing some inconsistency or wrong sizing of the PDM. I do agree with you that warning would probably be good. |
|
Thanks @pipiche38 that makes sense! |
|
Looks good, thanks ! |
I assume this appeared since I updated my zigate 1 from
3.1dto3.21this morning.I saw a strange closed PR here: #107 and the underlying issue is this one I guess: #104
Is there a way to easily test what I did in home assistant? I could copy paste the api.py and application.py into the home assistant folder but it seems a little by messy right?