Skip to content

Sync up to new zigpy changes.#34

Merged
sanyatuning merged 11 commits intozigpy:new-zigpy-init/devfrom
Adminiuga:new-zigpy-init/01-new-zigpy-init
Apr 15, 2020
Merged

Sync up to new zigpy changes.#34
sanyatuning merged 11 commits intozigpy:new-zigpy-init/devfrom
Adminiuga:new-zigpy-init/01-new-zigpy-init

Conversation

@Adminiuga
Copy link
Contributor

Implement new zigpy initialization and support for radio lib configuration schemas in https://github.com/zigpy/zigpy/commits/new-zigpy-init/dev

This would allow each radio lib to extend the zigpy configuration schema by adding radio specific configuration options.
Corresponding HA changes are currently in https://github.com/Adminiuga/home-assistant/tree/experimental/new-zigpy-init
I've tested this PR with CC2531 and it seems to work fine

@sanyatuning
Copy link
Collaborator

Very nice work. Can I add more config options like rts/cts?

@Adminiuga
Copy link
Contributor Author

Yep, can add flow control. give me a few.

@Adminiuga
Copy link
Contributor Author

For flow control, would you ever use "xonxoff" ???

Add "flow_control" key to "device" section of configuration dict,
supporting "software", "hardware" or None for flow control.
@Adminiuga Adminiuga requested a review from sanyatuning April 14, 2020 21:58
@Adminiuga
Copy link
Contributor Author

You can now request specific flow control settings by adding flow_control key to configuration dict, eg:

{
    "database_flle": "/config/zigbee.db",
    "device": {
        "path": "auto",
        "baudrate": 115200,
        "flow_control": None   # or "software" for xonxoff or "hardware" for rtscts
    }
}

@Adminiuga
Copy link
Contributor Author

@sanyatuning review/merge when you have a change. I'd like to add another PR to add a "probe" method to validate the right port is being used. Currently in config flow we go through the whole zigpy initialization to validate the port which is an overkill. The "probe" just going to send one command and on successful response we consider this being the right port

@Adminiuga Adminiuga mentioned this pull request Apr 15, 2020
@Hedda
Copy link
Contributor

Hedda commented Apr 15, 2020

@Adminiuga Nice! @sanyatuning I guess this type of extension of the zigpy configuration schema by adding radio specific configuration options could also be made work with a "TX Power" (TX_PWR) setting for Power Amplifier (PA) configuration of TI CC modules as requested in #33 for zigpy-cc plus zigpy/zigpy#372 and zigpy/zigpy#364 for zigpy?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants