Skip to content

Remove legacy hardcoded attributes for lumi.airrtc.agl001 #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cl445 wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Remove legacy hardcoded attributes for lumi.airrtc.agl001 #621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 0 additions & 43 deletions zha/application/platforms/binary_sensor/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,49 +331,6 @@ class XiaomiPlugConsumerConnected(BinarySensor):
_attr_translation_key: str = "consumer_connected"


@MULTI_MATCH(cluster_handler_names="opple_cluster", models={"lumi.airrtc.agl001"})
class AqaraThermostatWindowOpen(BinarySensor):
"""ZHA Aqara thermostat window open binary sensor."""

_attribute_name = "window_open"
_unique_id_suffix = "window_open"
_attr_device_class: BinarySensorDeviceClass = BinarySensorDeviceClass.WINDOW


@MULTI_MATCH(cluster_handler_names="opple_cluster", models={"lumi.airrtc.agl001"})
class AqaraThermostatValveAlarm(BinarySensor):
"""ZHA Aqara thermostat valve alarm binary sensor."""

_attribute_name = "valve_alarm"
_unique_id_suffix = "valve_alarm"
_attr_device_class: BinarySensorDeviceClass = BinarySensorDeviceClass.PROBLEM
_attr_translation_key: str = "valve_alarm"


@CONFIG_DIAGNOSTIC_MATCH(
cluster_handler_names="opple_cluster", models={"lumi.airrtc.agl001"}
)
class AqaraThermostatCalibrated(BinarySensor):
"""ZHA Aqara thermostat calibrated binary sensor."""

_attribute_name = "calibrated"
_unique_id_suffix = "calibrated"
_attr_entity_category: EntityCategory = EntityCategory.DIAGNOSTIC
_attr_translation_key: str = "calibrated"


@CONFIG_DIAGNOSTIC_MATCH(
cluster_handler_names="opple_cluster", models={"lumi.airrtc.agl001"}
)
class AqaraThermostatExternalSensor(BinarySensor):
"""ZHA Aqara thermostat external sensor binary sensor."""

_attribute_name = "sensor"
_unique_id_suffix = "sensor"
_attr_entity_category: EntityCategory = EntityCategory.DIAGNOSTIC
_attr_translation_key: str = "external_sensor"


@MULTI_MATCH(cluster_handler_names="opple_cluster", models={"lumi.sensor_smoke.acn03"})
class AqaraLinkageAlarmState(BinarySensor):
"""ZHA Aqara linkage alarm state binary sensor."""
Expand Down
18 changes: 0 additions & 18 deletions zha/application/platforms/number/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -757,24 +757,6 @@ class AqaraPetFeederPortionWeight(NumberConfigurationEntity):
_attr_native_unit_of_measurement: str = UnitOfMass.GRAMS


@CONFIG_DIAGNOSTIC_MATCH(
cluster_handler_names="opple_cluster", models={"lumi.airrtc.agl001"}
)
class AqaraThermostatAwayTemp(NumberConfigurationEntity):
"""Aqara away preset temperature configuration entity."""

_unique_id_suffix = "away_preset_temperature"
_attr_entity_category = EntityCategory.CONFIG
_attr_native_min_value: float = 5
_attr_native_max_value: float = 30
_multiplier: float = 0.01
_attribute_name = "away_preset_temperature"
_attr_translation_key: str = "away_preset_temperature"

_attr_mode: NumberMode = NumberMode.SLIDER
_attr_native_unit_of_measurement: str = UnitOfTemperature.CELSIUS


@CONFIG_DIAGNOSTIC_MATCH(
cluster_handler_names=CLUSTER_HANDLER_THERMOSTAT,
stop_on_match_group=CLUSTER_HANDLER_THERMOSTAT,
Expand Down
20 changes: 0 additions & 20 deletions zha/application/platforms/select.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -667,26 +667,6 @@ class AqaraPetFeederMode(ZCLEnumSelectEntity):
_attr_translation_key: str = "feeding_mode"


class AqaraThermostatPresetMode(types.enum8):
"""Thermostat preset mode."""

Manual = 0x00
Auto = 0x01
Away = 0x02


@CONFIG_DIAGNOSTIC_MATCH(
cluster_handler_names="opple_cluster", models={"lumi.airrtc.agl001"}
)
class AqaraThermostatPreset(ZCLEnumSelectEntity):
"""Representation of an Aqara thermostat preset configuration entity."""

_unique_id_suffix = "preset"
_attribute_name = "preset"
_enum = AqaraThermostatPresetMode
_attr_translation_key: str = "preset"


class SonoffPresenceDetectionSensitivityEnum(types.enum8):
"""Enum for detection sensitivity select entity."""

Expand Down
33 changes: 0 additions & 33 deletions zha/application/platforms/switch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -653,39 +653,6 @@ class TuyaChildLockSwitch(ConfigurableAttributeSwitch):
_attr_translation_key = "child_lock"


@CONFIG_DIAGNOSTIC_MATCH(
cluster_handler_names="opple_cluster", models={"lumi.airrtc.agl001"}
)
class AqaraThermostatWindowDetection(ConfigurableAttributeSwitch):
"""Representation of an Aqara thermostat window detection configuration entity."""

_unique_id_suffix = "window_detection"
_attribute_name = "window_detection"
_attr_translation_key = "window_detection"


@CONFIG_DIAGNOSTIC_MATCH(
cluster_handler_names="opple_cluster", models={"lumi.airrtc.agl001"}
)
class AqaraThermostatValveDetection(ConfigurableAttributeSwitch):
"""Representation of an Aqara thermostat valve detection configuration entity."""

_unique_id_suffix = "valve_detection"
_attribute_name = "valve_detection"
_attr_translation_key = "valve_detection"


@CONFIG_DIAGNOSTIC_MATCH(
cluster_handler_names="opple_cluster", models={"lumi.airrtc.agl001"}
)
class AqaraThermostatChildLock(ConfigurableAttributeSwitch):
"""Representation of an Aqara thermostat child lock configuration entity."""

_unique_id_suffix = "child_lock"
_attribute_name = "child_lock"
_attr_translation_key = "child_lock"


@CONFIG_DIAGNOSTIC_MATCH(
cluster_handler_names="opple_cluster", models={"lumi.sensor_smoke.acn03"}
)
Expand Down
14 changes: 0 additions & 14 deletions zha/zigbee/cluster_handlers/manufacturerspecific.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,20 +162,6 @@ def __init__(self, cluster: zigpy.zcl.Cluster, endpoint: Endpoint) -> None:
"serving_size": True,
"portion_weight": True,
}
elif self.cluster.endpoint.model == "lumi.airrtc.agl001":
self.ZCL_INIT_ATTRS = {
"system_mode": True,
"preset": True,
"window_detection": True,
"valve_detection": True,
"valve_alarm": True,
"child_lock": True,
"away_preset_temperature": True,
"window_open": True,
"calibrated": True,
"schedule": True,
"sensor": True,
}
elif self.cluster.endpoint.model == "lumi.sensor_smoke.acn03":
self.ZCL_INIT_ATTRS = {
"buzzer_manual_mute": True,
Expand Down
Loading