Add custom device class for Tuya TY0201 sensor #4319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces TY0201Device with direction fix logic to handle incorrect ZCL direction in Tuya TY0201 temperature and humidity sensors. Updates the quirk to use the new device class and removes the tuya_enchantment call.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #4319 +/- ##
=======================================
Coverage 92.13% 92.13%
=======================================
Files 358 358
Lines 11919 11931 +12
=======================================
+ Hits 10981 10993 +12
Misses 938 938 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Introduces a test to verify that the TY0201 quirk correctly handles devices sending ZCL commands with an incorrect direction. The test ensures no direction-related warnings are logged and that the custom TY0201Device class is used.
zimme
force-pushed
the
ty0201-direction
branch
from
22cccb1 to
fcf23ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Introduces TY0201Device with direction fix logic to handle incorrect ZCL direction in Tuya TY0201 temperature and humidity sensors. Updates the quirk to use the new device class and removes the tuya_enchantment call.
Fixes zigpy/zigpy#1640 (comment).
Additional information
This is a quirk specific fix for
_TZ3000_zl1kmjqx(and friends) but I saw in zigpy/zigpy#1640 that there seems to be more Tuya devices that have this wrong direction thing going on for different clusters.Perhaps a solution to introduce a TuyaCustomDevice class with this direction flipping logic similar to Aqara/Xiaomi, that will be used as the base for the current base classes, should be done instead of quirk specific fixes?
Device diagnostics
Checklist
pre-commitchecks pass / the code has been formatted using Black