Expose the 'multicolor' command on additional Hue lights #4318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the Akari downlight, Discover floodlight and Lightstrip Solo
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #4318 +/- ##
=======================================
Coverage 92.13% 92.13%
=======================================
Files 358 358
Lines 11919 11922 +3
=======================================
+ Hits 10981 10984 +3
Misses 938 938 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3 tasks
|
@TheJulianJES - when I created this PR, I added information to the Proposed Change, Additional Information and I also uploaded Device Diagnostics for the three devices concerned so I'm not sure why none of that is visible above. Let me know if you need me come back and add further information. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Added the Akari downlight, Discover floodlight and Lightstrip Solo
Added support for 'multicolor' command for more Hue devices.
Additional information
Extends support added by PR 4076 and 3664
Device diagnostics
zha-01JTWSK5QQ8MVHXRQYFG0V6GK8-Philips Hue Discover Outdoor Floodlight RGBCCT-cea73e176a6bbffd9f8e0ebb5abf5456.json
You can find the diagnostics information by going
zha-01JTWSK5QQ8MVHXRQYFG0V6GK8-Philips Hue Akari Downlight-077929e0069ea90ed22233f2b43aba06.json
to the device page, clicking the
three dots, and then by clicking on "Download diagnostics". Drag-and-drop the
downloaded file into this section.
zha-01JTWSK5QQ8MVHXRQYFG0V6GK8-Philips Hue Lightstrip Solo-2eb70bc25a2d10a0be9780f96f914449.json
Checklist
pre-commitchecks pass / the code has been formatted using Black