Skip to content

Conversation

TheJulianJES
Copy link
Collaborator

@TheJulianJES TheJulianJES commented Apr 30, 2025

Proposed change

This PR fixes an issue where various config options would not show up for the following Tuya temperature sensors:

This also removes unnecessary "fixing" of negative temperature values for these devices.
Both Tuya spells are also enabled due to Z2M source mentioning this being required (might not be true, but doesn't hurt to enable this).
Affected devices that are not reporting need to be re-paired on a version with this bugfix.

Additional information

Follow-up PR to:

PR is untested, but looking good when comparing to Z2M code.

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

@TheJulianJES TheJulianJES added Tuya Request/PR regarding a Tuya device bugfix This PR fixes a bug labels Apr 30, 2025
Copy link

codecov bot commented Apr 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.19%. Comparing base (d34ae41) to head (3c5c58f).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #4037   +/-   ##
=======================================
  Coverage   91.19%   91.19%           
=======================================
  Files         335      335           
  Lines       10886    10886           
=======================================
  Hits         9928     9928           
  Misses        958      958           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TheJulianJES TheJulianJES mentioned this pull request Apr 30, 2025
@TheJulianJES TheJulianJES merged commit c2f64fd into zigpy:dev Apr 30, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix This PR fixes a bug Tuya Request/PR regarding a Tuya device

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant