Add quirk for Sonoff ZBMINIR2 #3428
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #3428 +/- ##
==========================================
+ Coverage 88.71% 89.44% +0.73%
==========================================
Files 306 312 +6
Lines 9820 10056 +236
==========================================
+ Hits 8712 8995 +283
+ Misses 1108 1061 -47 ☔ View full report in Codecov by Sentry. |
|
Hi @TheJulianJES, I've created a PR. Is there anything I need to do before merging it? |
| async def _read_attributes( | ||
| self, | ||
| attribute_ids: list[t.uint16_t], | ||
| *args, | ||
| manufacturer: int | t.uint16_t | None = None, | ||
| **kwargs, | ||
| ): | ||
| """Read attributes ZCL foundation command.""" | ||
| return await super()._read_attributes( | ||
| attribute_ids, | ||
| *args, | ||
| manufacturer=foundation.ZCLHeader.NO_MANUFACTURER_ID, | ||
| **kwargs, | ||
| ) | ||
|
|
||
| @property | ||
| def _is_manuf_specific(self): | ||
| return False |
There was a problem hiding this comment.
Hmm, in the future, we should have a better solution for this, so we don't need to duplicate it across all quirks.
| edge_trigger = 0x00 | ||
| pulse_trigger = 0x01 | ||
| normally_off_follow_trigger = 0x02 | ||
| normally_on_follow_trigger = 0x82 |
There was a problem hiding this comment.
I'll have to check which naming convention we want to use here.
Other possibilities include: EdgeTrigger, Edge_Trigger, and Edge_trigger.
|
Thank you very much for your assistance. |
|
@TheJulianJES Can this be merged? Z2M has had proper support for this device for a while, and it would be a shame to block it over variable naming. |
Proposed change
Add quirk for Sonoff ZBMINIR2
Additional information
Checklist
pre-commitchecks pass / the code has been formatted using Black