Add IEKA Symfonisk Gen2 v1/v2 support #2273
Conversation
Pull Request Test Coverage Report for Build 4497921857
💛 - Coveralls |
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## dev #2273 +/- ##
==========================================
+ Coverage 83.91% 83.99% +0.07%
==========================================
Files 260 261 +1
Lines 8214 8252 +38
==========================================
+ Hits 6893 6931 +38
Misses 1321 1321
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Great thanks to @javicalle and @TheJulianJES for making the code part working and nice implemented and our brave users for testing and feed back !!And also @MichelBrodatzki for the V1 first version PR that was making the ground for this quirk. Next up is is the Gen 2 of OnOff, OpenClose and ShortCut buttons then IKEA is releasing them !! |
TheJulianJES
changed the title
There was a problem hiding this comment.
Added a few notes.
Hopefully I'll be able to look at the power configuration stuff in the coming days. I'm pretty sure that can be cleaned up, so we don't duplicate it everywhere.
(We might also want to use the non-doubling clusters for other IKEA devices then?)
|
I have making the no braking things and little more that was failing between the changes with the snaking. The class naming need being fixed then of 4 named IKEA controllers is 2 different naming used (Starkvind, Shurtcut, Symfonisk) and IKEA is always using upper case for product names (I think its copyright / trademarks thins behind that). The corde working changes i have not doing then i dont knowing if its working or not and i cant diag it so better you is doing it and i can testing it. Was finding one more not snaked that have being added in constants: zha-device-handlers/zhaquirks/const.py Line 62 in fa60b9d that i think you shall putting on the tOOdOO lIST. |
|
Have updating my test system and changing the 2 local import (IKEA and constants) and testing all DA for both versions. V1 13 DA all working OK = I is getting the right |
|
I've split up the battery clusters part into: #2284 and tried to make it a bit cleaner, so the constant attributes aren't copy-/pasted. Note: It's still untested if that even works, but if I'm thinking correctly, it should. I'll try to test that in the next few days. I will rebase this PR once the battery one gets merged, so leave this PR open. (No need for you to do anything) |
TheJulianJES
force-pushed
the
Symfoos2-V1-and-V2
branch
from
39cf172
to
35d0c1b
Compare
|
Alright, I've rebased the PR and made some small changes (that hopefully aren't breaking). |
|
Updating the INIT and the quirk to the latest commit and patching the imports for using the local quirk ones and 4 not working restarts ZHA was starting OK and loading the automatons OK (if getting delay HA is not loading them and cant getting them loaded without restart of HA). Have testing all V1 and V2 DA and all is working as expected !! So all is looking OK also battery reporting then reading it from the device: Thanks for helping not code warier getting the devices supported ! |
|
You can committing it then its working 100% for V1 and all DAs is working for V2 but no events for EP 2 and 3 until ZHA is fixed and its better then not working at all and its not braking thing and user can doing binding with ZHA toolkit if they like until all is merged and having full working devices in there system. Also one great thanks to @MichelBrodatzki for the initial V1 code that was making its easier doing the V2 working well and our ZHA devs for helping with the fixing the problems on the road. |
|
Koenkk/zigbee-herdsman-converters#5583 (comment) But i understand that other have not getting all in place for both versions and was throng it in without understanding how the V1 and 2 is working and dont have any firmware for upgrading to V2 without Dirigera dresden-elektronik/deconz-rest-plugin#6803 |
|
Thanks JES !! |
|
Only for information have IKEA updated the firmware in DIRIGERA for this device to If its possible i like keeping my 2 remotes with original and and first update then i trying helping our danish friends that making wall switches of IKEA remotes and they looks having problem with then for the moment. So if getting not working DA with the latest firmware pleas reporting it and we is trying getting it working with some debug logging and testing. |
Add DA for Symfonisk Gen 2 with shipping firmware (V1) and first OTA updated via Dirigera (V2).
The V1 is using raw commands on EP1.
V2 is using Matter Switch ZCL commands on 2 extra EP but with IKEA manufacture cluster then the Matter cluster is not in ZCL R8. V2 also need the 2 extra EP being bounded and one PR is made in ZHA for doing it nice but this version is using OnOff Custer as one temporary solution until the ZHA PR is merged.
Also V1 is using IKEA old battery reporting (100%) and V2 is using Zigbee standard (200%) so have adding new updated power cluster class and also for upcoming OnOff, OpenCloce and ShortCut button Gen 2 that is in the pipe,
Adding more constants for getting Matter Switch functionality working OK.
Toggle have not hold as left and right and only sending one command. Up and down is sending single and repeating the command then being held.
V1 is only sending ShortCut command single, double and held.
V2 is sending initial press for all commands and then single pressed and release double is sending initial multi press multiple reseal with arg 2 (2 presses) and held is sending held and and hold release.
Fixes: #2223
Depends on: home-assistant/core#89623